Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas Throttling #185

Merged
merged 7 commits into from
Nov 3, 2021
Merged

Gas Throttling #185

merged 7 commits into from
Nov 3, 2021

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Oct 27, 2021

Description:
Describe the propsoed system for Gas Throttling in 0.20.0

Signed-off-by: Danno Ferrin danno.ferrin@hedera.com

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Describe the propsoed system for Gas Throttling in 0.20.0

Signed-off-by: Danno Ferrin <danno.ferrin@hedera.com>
HIP/hip-gas-throttling.md Outdated Show resolved Hide resolved
HIP/hip-gas-throttling.md Outdated Show resolved Hide resolved
shemnon and others added 5 commits October 28, 2021 13:32
* changed some response codes
* clarified precheck and consensus throttle may differ

Signed-off-by: Danno Ferrin <danno.ferrin@hedera.com>
Signed-off-by: Serg Metelin <sergey.metelin@hedera.com>
Tweaking header formatting aligned with the new HIP-1 process

Signed-off-by: Serg Metelin <sergey.metelin@hedera.com>
Updated the HIP number based on the PR # rather than sequential (aligned with the new HIP process)

Signed-off-by: Serg Metelin <sergey.metelin@hedera.com>
Added a `discussions-to` link

Signed-off-by: Serg Metelin <sergey.metelin@hedera.com>
sergmetelin
sergmetelin previously approved these changes Nov 3, 2021
Copy link
Contributor

@sergmetelin sergmetelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

HIP/hip-gas-throttling.md Outdated Show resolved Hide resolved
HIP/hip-gas-throttling.md Outdated Show resolved Hide resolved
Updated `last-call-date-time` to align with the 2 weeks window for community review

Signed-off-by: Serg Metelin <sergey.metelin@hedera.com>
Copy link
Contributor

@sergmetelin sergmetelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving for the last-call-date-time alignment

@sergmetelin sergmetelin merged commit 13302be into hashgraph:master Nov 3, 2021
jayv80 pushed a commit to jayv80/hedera-improvement-proposal that referenced this pull request Dec 20, 2021
* Gas Throttling

Describe the propsoed system for Gas Throttling in 0.20.0

Signed-off-by: Danno Ferrin <danno.ferrin@hedera.com>

* review changes

* changed some response codes
* clarified precheck and consensus throttle may differ

Signed-off-by: Danno Ferrin <danno.ferrin@hedera.com>

* Update and rename hip-gas-throttling.md to hip-34.md

Signed-off-by: Serg Metelin <sergey.metelin@hedera.com>

* Update hip-34.md

Tweaking header formatting aligned with the new HIP-1 process

Signed-off-by: Serg Metelin <sergey.metelin@hedera.com>

* Update and rename hip-34.md to hip-185.md

Updated the HIP number based on the PR # rather than sequential (aligned with the new HIP process)

Signed-off-by: Serg Metelin <sergey.metelin@hedera.com>

* Update hip-185.md

Added a `discussions-to` link

Signed-off-by: Serg Metelin <sergey.metelin@hedera.com>

* Update hip-185.md

Updated `last-call-date-time` to align with the 2 weeks window for community review

Signed-off-by: Serg Metelin <sergey.metelin@hedera.com>

Co-authored-by: Serg Metelin <sergey.metelin@hedera.com>
Signed-off-by: VercammenJo <jo.vercammen@in2scope.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants