-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gas Throttling #185
Merged
Merged
Gas Throttling #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Describe the propsoed system for Gas Throttling in 0.20.0 Signed-off-by: Danno Ferrin <danno.ferrin@hedera.com>
* changed some response codes * clarified precheck and consensus throttle may differ Signed-off-by: Danno Ferrin <danno.ferrin@hedera.com>
Signed-off-by: Serg Metelin <sergey.metelin@hedera.com>
Tweaking header formatting aligned with the new HIP-1 process Signed-off-by: Serg Metelin <sergey.metelin@hedera.com>
Updated the HIP number based on the PR # rather than sequential (aligned with the new HIP process) Signed-off-by: Serg Metelin <sergey.metelin@hedera.com>
Added a `discussions-to` link Signed-off-by: Serg Metelin <sergey.metelin@hedera.com>
sergmetelin
previously approved these changes
Nov 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updated `last-call-date-time` to align with the 2 weeks window for community review Signed-off-by: Serg Metelin <sergey.metelin@hedera.com>
sergmetelin
approved these changes
Nov 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving for the last-call-date-time
alignment
jayv80
pushed a commit
to jayv80/hedera-improvement-proposal
that referenced
this pull request
Dec 20, 2021
* Gas Throttling Describe the propsoed system for Gas Throttling in 0.20.0 Signed-off-by: Danno Ferrin <danno.ferrin@hedera.com> * review changes * changed some response codes * clarified precheck and consensus throttle may differ Signed-off-by: Danno Ferrin <danno.ferrin@hedera.com> * Update and rename hip-gas-throttling.md to hip-34.md Signed-off-by: Serg Metelin <sergey.metelin@hedera.com> * Update hip-34.md Tweaking header formatting aligned with the new HIP-1 process Signed-off-by: Serg Metelin <sergey.metelin@hedera.com> * Update and rename hip-34.md to hip-185.md Updated the HIP number based on the PR # rather than sequential (aligned with the new HIP process) Signed-off-by: Serg Metelin <sergey.metelin@hedera.com> * Update hip-185.md Added a `discussions-to` link Signed-off-by: Serg Metelin <sergey.metelin@hedera.com> * Update hip-185.md Updated `last-call-date-time` to align with the 2 weeks window for community review Signed-off-by: Serg Metelin <sergey.metelin@hedera.com> Co-authored-by: Serg Metelin <sergey.metelin@hedera.com> Signed-off-by: VercammenJo <jo.vercammen@in2scope.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Describe the propsoed system for Gas Throttling in 0.20.0
Signed-off-by: Danno Ferrin danno.ferrin@hedera.com
Related issue(s):
Fixes #
Notes for reviewer:
Checklist