Only executes when response is null

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
hashgraph · Oct 21, 2024 · c66cad2 · c66cad2
1 parent e1e5736
commit c66cad2
Showing 1 changed file with 13 additions and 14 deletions.
diff --git a/packages/relay/src/lib/clients/sdkClient.ts b/packages/relay/src/lib/clients/sdkClient.ts
@@ -757,25 +757,24 @@ export class SDKClient {
       );
 
       if (!transactionResponse) {
+        const transactionId = transaction.transactionId ? transaction.transactionId.toString() : false;
+        console.log('Transaction id', transactionId);
+        if (transactionId) {
+          try {
+            const transactionFromMirrorNode = await this.mirrorNodeClient.getTransactionById(
+              transactionId,
+              requestDetails,
+            );
+            this.logger.warn('Transaction found', transactionFromMirrorNode);
+          } catch (e) {
+            this.logger.warn('Transaction not found in mirror node', e);
+          }
+        }
         throw predefined.INTERNAL_ERROR(
           `${requestDetails.formattedRequestId} TTransaction execution returns a null value: transactionId=${transaction.transactionId}, callerName=${callerName}, txConstructorName=${txConstructorName}`,
         );
       }
 
-      const transactionId = transaction.transactionId ? transaction.transactionId.toString() : false;
-      console.log('Transaction id', transactionId);
-      if (transactionId) {
-        try {
-          const transactionFromMirrorNode = await this.mirrorNodeClient.getTransactionById(
-            transactionId,
-            requestDetails,
-          );
-          this.logger.warn('Transaction found', transactionFromMirrorNode);
-        } catch (e) {
-          this.logger.warn('Transaction not found in mirror node', e);
-        }
-      }
-
       return transactionResponse;
     } finally {
       if (transactionId?.length) {