Script executing execution api tests #1621

konstantinabl · 2023-08-09T14:58:36Z

Description:

The goal of this PR is to introduce a script which runs whenever a PR is created and tests if we conform to the JSON RPC Specification
Related issue(s):

Fixes #
#1475
Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

natanasow

LG, some good-to-have fixes and we're ready 🚀

scripts/check-ethereum-api-schema.js

codecov-commenter · 2023-09-05T08:57:09Z

Codecov Report

Patch and project coverage have no change.

Comparison is base (f28b721) 76.65% compared to head (47c2cf9) 76.65%.
Report is 2 commits behind head on main.

❗ Current head 47c2cf9 differs from pull request most recent head 6254849. Consider uploading reports for the commit 6254849 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1621   +/-   ##
=======================================
  Coverage   76.65%   76.65%           
=======================================
  Files          39       39           
  Lines        2913     2913           
  Branches      584      584           
=======================================
  Hits         2233     2233           
  Misses        499      499           
  Partials      181      181

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

natanasow

LG, some suggestions TBD

packages/server/package.json

packages/server/tests/acceptance/conformityTests.spec.ts

Nana-EC

Nice work.
Some suggestions

.github/workflows/acceptance-public.yml

packages/server/package.json

packages/server/tests/acceptance/conformityTests.spec.ts

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Nana-EC

Approving.
Left some non blocking comment which I would like addressed but can be done in a follow up separate PR if desired

packages/server/tests/acceptance/conformityTests.spec.ts

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

sonarqubecloud · 2023-09-12T09:55:05Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

* Draft of script executing execution api tests Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Refactors script to make it more readable and modular Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes PR comments Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Resolves conflict Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes for some transaction methods and sendRawTransaction Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes package-lock.json Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Tries to fix package-lock.json conflicts Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Package lock.json Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Refactors script to handle different transaction for getTransactionByHash Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes script for all methods and optimizes it Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Sets nonce via getTransactionCount Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Refactors main to make it more readable Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds execution api repo as dependency Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Refactors script to test file Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Deletes script Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds command for executing new tests Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds conformity tests to github workflow Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds new dependencies to package-lock Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes typo in package.json Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Changes github workflow name Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds comments and docs; Takes bytecode from json Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes script name for conformity tests Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Removes redundant variable; moves variable to const Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds specifig tag to execution apis repo Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Replaces file name string with constant variables Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds more informative variables for request.param checks Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Combines sendrawTransaction checks Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> --------- Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com>

* Draft of script executing execution api tests Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Refactors script to make it more readable and modular Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes PR comments Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Resolves conflict Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes for some transaction methods and sendRawTransaction Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes package-lock.json Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Tries to fix package-lock.json conflicts Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Package lock.json Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Refactors script to handle different transaction for getTransactionByHash Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes script for all methods and optimizes it Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Sets nonce via getTransactionCount Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Refactors main to make it more readable Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds execution api repo as dependency Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Refactors script to test file Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Deletes script Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds command for executing new tests Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds conformity tests to github workflow Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds new dependencies to package-lock Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes typo in package.json Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Changes github workflow name Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds comments and docs; Takes bytecode from json Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes script name for conformity tests Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Removes redundant variable; moves variable to const Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds specifig tag to execution apis repo Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Replaces file name string with constant variables Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Adds more informative variables for request.param checks Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Combines sendrawTransaction checks Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> --------- Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: Mo Shaikjee <shaikjeemohammed@gmail.com>

konstantinabl linked an issue Aug 9, 2023 that may be closed by this pull request

[Design] Explore continuous automated RPC API schema verification #1475

Closed

konstantinabl requested review from Ivo-Yankov, georgi-l95 and natanasow August 9, 2023 14:59

Nana-EC added this to the 0.30.0 milestone Aug 9, 2023

Nana-EC added enhancement New feature or request P2 labels Aug 9, 2023

Nana-EC assigned konstantinabl Aug 9, 2023

natanasow previously approved these changes Aug 11, 2023

View reviewed changes

konstantinabl dismissed natanasow’s stale review via f4ee491 August 17, 2023 07:22

github-advanced-security bot found potential problems Aug 17, 2023

View reviewed changes

scripts/check-ethereum-api-schema.js Fixed Show fixed Hide fixed

konstantinabl force-pushed the 1475-design-explore-continuous-automated-rpc-api-schema-verification branch 3 times, most recently from a47925c to 76c148c Compare August 18, 2023 12:32

AlfredoG87 modified the milestones: 0.30.0, 0.31.0 Aug 21, 2023

konstantinabl force-pushed the 1475-design-explore-continuous-automated-rpc-api-schema-verification branch 2 times, most recently from 1b1345e to ee7093e Compare September 5, 2023 07:07

konstantinabl marked this pull request as ready for review September 5, 2023 07:50

konstantinabl requested a review from a team as a code owner September 5, 2023 07:50

konstantinabl requested a review from david-bakin-sl September 5, 2023 07:50

konstantinabl changed the title ~~Draft of script executing execution api tests~~ Script executing execution api tests Sep 5, 2023

konstantinabl force-pushed the 1475-design-explore-continuous-automated-rpc-api-schema-verification branch 2 times, most recently from 4fb240f to 03e7f40 Compare September 5, 2023 11:48

ebadiere modified the milestones: 0.31.0, 0.32.0 Sep 6, 2023

konstantinabl requested review from AlfredoG87, ebadiere and Nana-EC as code owners September 7, 2023 14:11

konstantinabl added 3 commits September 7, 2023 17:16

Adds command for executing new tests

58094b0

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Adds conformity tests to github workflow

ae57bfa

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Adds new dependencies to package-lock

4b3d291

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

konstantinabl force-pushed the 1475-design-explore-continuous-automated-rpc-api-schema-verification branch from 7ee56de to 4b3d291 Compare September 7, 2023 14:16

Fixes typo in package.json

c32272d

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

konstantinabl requested a review from natanasow September 7, 2023 14:40

natanasow reviewed Sep 7, 2023

View reviewed changes

packages/server/package.json Outdated Show resolved Hide resolved

packages/server/tests/acceptance/conformityTests.spec.ts Outdated Show resolved Hide resolved

packages/server/tests/acceptance/conformityTests.spec.ts Show resolved Hide resolved

Nana-EC requested changes Sep 7, 2023

View reviewed changes

konstantinabl added 5 commits September 8, 2023 17:19

Changes github workflow name

22e2efc

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Adds comments and docs; Takes bytecode from json

afb18a9

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Fixes script name for conformity tests

77e1bde

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Removes redundant variable; moves variable to const

50a75c0

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Adds specifig tag to execution apis repo

efe9816

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

konstantinabl requested review from natanasow and Nana-EC September 11, 2023 10:56

Nana-EC previously approved these changes Sep 11, 2023

View reviewed changes

packages/server/tests/acceptance/conformityTests.spec.ts Show resolved Hide resolved

packages/server/tests/acceptance/conformityTests.spec.ts Outdated Show resolved Hide resolved

packages/server/tests/acceptance/conformityTests.spec.ts Show resolved Hide resolved

konstantinabl dismissed Nana-EC’s stale review via 4c1bb3d September 12, 2023 08:26

konstantinabl force-pushed the 1475-design-explore-continuous-automated-rpc-api-schema-verification branch from 4c1bb3d to 023576c Compare September 12, 2023 08:52

Replaces file name string with constant variables

f35aa56

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

konstantinabl force-pushed the 1475-design-explore-continuous-automated-rpc-api-schema-verification branch from 023576c to f35aa56 Compare September 12, 2023 08:56

konstantinabl added 2 commits September 12, 2023 12:05

Adds more informative variables for request.param checks

fff54eb

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

Combines sendrawTransaction checks

6254849

Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>

konstantinabl requested a review from Nana-EC September 12, 2023 09:55

Nana-EC approved these changes Sep 13, 2023

View reviewed changes

konstantinabl merged commit 0f6df38 into main Sep 13, 2023

konstantinabl deleted the 1475-design-explore-continuous-automated-rpc-api-schema-verification branch September 13, 2023 06:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Script executing execution api tests #1621

Script executing execution api tests #1621

konstantinabl commented Aug 9, 2023 •

edited

Loading

natanasow left a comment

codecov-commenter commented Sep 5, 2023 •

edited

Loading

natanasow left a comment

Nana-EC left a comment

Nana-EC left a comment

sonarqubecloud bot commented Sep 12, 2023

Script executing execution api tests #1621

Script executing execution api tests #1621

Conversation

konstantinabl commented Aug 9, 2023 • edited Loading

natanasow left a comment

Choose a reason for hiding this comment

codecov-commenter commented Sep 5, 2023 • edited Loading

Codecov Report

natanasow left a comment

Choose a reason for hiding this comment

Nana-EC left a comment

Choose a reason for hiding this comment

Nana-EC left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Sep 12, 2023

konstantinabl commented Aug 9, 2023 •

edited

Loading

codecov-commenter commented Sep 5, 2023 •

edited

Loading