Fix eth_getТransactionByHash does not return accesslist and yparity for 1559 and 2930 transactions
#1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1696 +/- ##
==========================================
+ Coverage 76.94% 77.81% +0.86%
==========================================
Files 39 26 -13
Lines 2859 2276 -583
Branches 575 464 -111
==========================================
- Hits 2200 1771 -429
+ Misses 479 362 -117
+ Partials 180 143 -37
☔ View full report in Codecov by Sentry. |
Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
konstantinabl
requested review from
AlfredoG87,
ebadiere,
lukelee-sl and
a team
as code owners
georgi-l95
changed the title
eth_getТransactionByHash does not return accesslist and yparity for 1559 and 2930 transactions
Nana-EC
approved these changes
Aug 31, 2023
konstantinabl
deleted the
1654-eth_gettransactionbyhash-does-not-return-accesslist-and-yparity-for-1559-and-2930-transactions
branch
ebadiere
pushed a commit
that referenced
this pull request
Sep 1, 2023
… for 1559 and 2930 transactions (#1696) * replaces v to yParit for 1559 and 2930 Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes tests Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes tests Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> --------- Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere
pushed a commit
that referenced
this pull request
Sep 18, 2023
… for 1559 and 2930 transactions (#1696) * replaces v to yParit for 1559 and 2930 Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes tests Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes tests Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> --------- Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere
pushed a commit
that referenced
this pull request
Sep 20, 2023
… for 1559 and 2930 transactions (#1696) * replaces v to yParit for 1559 and 2930 Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes tests Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes tests Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> --------- Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: ebadiere <ebadiere@gmail.com>
mshakeg
pushed a commit
to mshakeg/hedera-json-rpc-relay
that referenced
this pull request
Oct 18, 2023
… for 1559 and 2930 transactions (hashgraph#1696) * replaces v to yParit for 1559 and 2930 Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes tests Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> * Fixes tests Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> --------- Signed-off-by: Konstantina Blazhukova <konstantina.blajukova@gmail.com> Signed-off-by: Mo Shaikjee <shaikjeemohammed@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR modifies the models of the different type of Transactions, so for 1559 and 2930 the v value is deprecated and yParity is used instead.
Related issue(s):
Fixes #1654 #1655
Notes for reviewer:
Checklist