Return evm_address in eth_getTransactionByHash and eth_getTransactionReceipt #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
# Conflicts: # packages/relay/src/lib/clients/mirrorNodeClient.ts # packages/relay/src/lib/eth.ts # packages/server/tests/acceptance/rpc_batch1.spec.ts # packages/server/tests/helpers/assertions.ts
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1726 +/- ##
==========================================
+ Coverage 76.65% 76.74% +0.08%
==========================================
Files 39 39
Lines 2913 2915 +2
Branches 584 588 +4
==========================================
+ Hits 2233 2237 +4
+ Misses 499 496 -3
- Partials 181 182 +1
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Ivo-Yankov
requested review from
AlfredoG87,
ebadiere,
Nana-EC,
a team and
lukelee-sl
as code owners
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Nana-EC
requested changes
Sep 11, 2023
packages/relay/src/lib/eth.ts
Outdated
| @@ -1802,8 +1811,10 @@ export class EthImpl implements Eth { | |||
| const receipt: any = { | |||
| blockHash: toHash32(receiptResponse.block_hash), | |||
| blockNumber: numberTo0x(receiptResponse.block_number), | |||
| from: receiptResponse.from, | |||
| to: receiptResponse.to, | |||
| from: receiptResponse.from | |||
There was a problem hiding this comment.
Could move the undefined/null check into the resolveEvmAddress()
| Assertions.evmAddress(txByHash.from); | ||
| Assertions.longZeroAddress(txByHash.to); | ||
| Assertions.evmAddress(receipt.from); | ||
| Assertions.longZeroAddress(receipt.to); |
There was a problem hiding this comment.
Q: post HIP 729 shouldn't all new contract have a valid evm addresses?
I thought we were trying to return evm address values all the time when applicable?
There was a problem hiding this comment.
From what I've noticed, contracts that have been deployed via the SDK (using fileCreateTransaction still show a long-zero address in the mirror node instead of a proper evm address. Here are a couple of the latest contracts on testnet:
- 0.0.1581464 - returns long-zero
- 0.0.1581465 - returns evm address
There was a problem hiding this comment.
Very strange.
Can you open an issue on the services side so we can track this nuance.
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
|
Kudos, SonarCloud Quality Gate passed!
|
Nana-EC
approved these changes
Sep 13, 2023
ebadiere
pushed a commit
that referenced
this pull request
Sep 18, 2023
…Receipt (#1726) * wip: fix receipt format Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * feat: return evm format of from and to address Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: handle missing to Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * nit: fix code smells Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * test: add more test cases Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: code optimization Signed-off-by: Ivo Yankov <ivo@devlabs.bg> --------- Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere
pushed a commit
that referenced
this pull request
Sep 20, 2023
…Receipt (#1726) * wip: fix receipt format Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * feat: return evm format of from and to address Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: handle missing to Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * nit: fix code smells Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * test: add more test cases Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: code optimization Signed-off-by: Ivo Yankov <ivo@devlabs.bg> --------- Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Signed-off-by: ebadiere <ebadiere@gmail.com>
mshakeg
pushed a commit
to mshakeg/hedera-json-rpc-relay
that referenced
this pull request
Oct 18, 2023
…Receipt (hashgraph#1726) * wip: fix receipt format Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * feat: return evm format of from and to address Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * fix: handle missing to Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * nit: fix code smells Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * test: add more test cases Signed-off-by: Ivo Yankov <ivo@devlabs.bg> * chore: code optimization Signed-off-by: Ivo Yankov <ivo@devlabs.bg> --------- Signed-off-by: Ivo Yankov <ivo@devlabs.bg> Signed-off-by: Mo Shaikjee <shaikjeemohammed@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes the
toandfromaddresses returned byeth_getTransactionByHashandeth_getTransactionReceiptto always beevm_addressesinstead of long-zero whenever such an address exists. In all other cases a long-zero address is returned.Related issue(s):
Fixes #1710
Notes for reviewer:
Checklist