Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variable fixes. #1728

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

ebadiere
Copy link
Contributor

@ebadiere ebadiere commented Sep 7, 2023

Sets mirror node version and default value for the redis server in the acceptance tests.

Related issue(s):

Fixes #1706

Signed-off-by: ebadiere <ebadiere@gmail.com>
@ebadiere ebadiere requested review from AlfredoG87, Nana-EC and a team as code owners September 7, 2023 19:19
@ebadiere ebadiere self-assigned this Sep 7, 2023
@ebadiere ebadiere added the bug Something isn't working label Sep 7, 2023
@ebadiere ebadiere added this to the 0.32.0 milestone Sep 7, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebadiere ebadiere merged commit 24b48c4 into main Sep 8, 2023
@ebadiere ebadiere deleted the environment-variable-fixes-for-main branch September 8, 2023 15:37
ebadiere added a commit that referenced this pull request Sep 18, 2023
Signed-off-by: ebadiere <ebadiere@gmail.com>
ebadiere added a commit that referenced this pull request Sep 20, 2023
Signed-off-by: ebadiere <ebadiere@gmail.com>
mshakeg pushed a commit to mshakeg/hedera-json-rpc-relay that referenced this pull request Oct 18, 2023
Signed-off-by: ebadiere <ebadiere@gmail.com>
Signed-off-by: Mo Shaikjee <shaikjeemohammed@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Release 0.31
3 participants