Fix: eth_estimateGas error when providing gas field
#1741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mirror node Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1741 +/- ##
==========================================
+ Coverage 76.83% 76.85% +0.01%
==========================================
Files 39 39
Lines 2914 2916 +2
Branches 585 586 +1
==========================================
+ Hits 2239 2241 +2
Misses 496 496
Partials 179 179
☔ View full report in Codecov by Sentry. |
AlfredoG87
requested review from
ebadiere,
lukelee-sl and
a team
as code owners
Nana-EC
approved these changes
Sep 13, 2023
ebadiere
pushed a commit
that referenced
this pull request
Sep 18, 2023
ebadiere
pushed a commit
that referenced
this pull request
Sep 20, 2023
mshakeg
pushed a commit
to mshakeg/hedera-json-rpc-relay
that referenced
this pull request
Oct 18, 2023
Adding 'gas' field to formatting before relaying the call data to the mirror node Signed-off-by: Alfredo Gutierrez <alfredo@swirldslabs.com> Signed-off-by: Mo Shaikjee <shaikjeemohammed@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
HotFix is being applied into
0.31via this PR #1740Addresses Issue 1738 by formatting
gasfield before sending the tx data to the mirror-node contracts/call endpoint.Mirror node is expecting a decimal number, and relay is getting a Hex string of the number.
Related issue(s):
Fixes #1738
Notes for reviewer:
I've verified and there are no other fields that need correct transformation from hex string to decimal number.
(see doc api of mirror node)
Checklist