chore: Upgrade node version to 20. #3245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Badiere <ebadiere@gmail.com>
Test Results 18 files - 1 235 suites - 23 29m 49s ⏱️ -56s For more details on these failures, see this check. Results for commit 3939165. ± Comparison against base commit a541583. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Signed-off-by: Eric Badiere <ebadiere@gmail.com>
|
ebadiere
requested review from
AlfredoG87,
Nana-EC and
a team
as code owners
quiet-node
added
internal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3245 +/- ##
==========================================
+ Coverage 83.17% 83.48% +0.31%
==========================================
Files 66 66
Lines 4314 4305 -9
Branches 843 846 +3
==========================================
+ Hits 3588 3594 +6
+ Misses 483 470 -13
+ Partials 243 241 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
ebadiere
added a commit
that referenced
this pull request
Nov 11, 2024
* chore: Upgrade node version to 20. Signed-off-by: Eric Badiere <ebadiere@gmail.com> * chore: Updated references to node 20. Signed-off-by: Eric Badiere <ebadiere@gmail.com> --------- Signed-off-by: Eric Badiere <ebadiere@gmail.com>
ebadiere
added a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR upgrades any leftover references from node version 18, to node version 20. It updates github workflows and cleans up some leftover commented out code.
Related issue(s):
Fixes #3156
Notes for reviewer:
Node version 20 was already referenced in the README.md and in most of the workflows. The conformity tests had some remaining version 18 references that were updated.
Checklist