Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extend the format checking via openrpcjson #3285

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

nadezhdapopovaa
Copy link
Contributor

Description:

  • updates conformity test to use relay's openrpc file for methods, which are not tested via ethereum/execution-api repo. We check if result is matching the pattern from our openrpc file;
  • there were few methods which were duplicated and update of few patterns.

Related issue(s):

Fixes #2728

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Nadezhda Popova <nadezhda.popova@limechain.tech>
Signed-off-by: Nadezhda Popova <nadezhda.popova@limechain.tech>
@nadezhdapopovaa nadezhdapopovaa linked an issue Nov 21, 2024 that may be closed by this pull request
@nadezhdapopovaa nadezhdapopovaa self-assigned this Nov 21, 2024
@nadezhdapopovaa nadezhdapopovaa marked this pull request as ready for review November 21, 2024 14:35
@nadezhdapopovaa nadezhdapopovaa added the enhancement New feature or request label Nov 21, 2024
@nadezhdapopovaa nadezhdapopovaa added this to the 0.61.0 milestone Nov 21, 2024
@nadezhdapopovaa nadezhdapopovaa changed the title 2728 extend the format checking via openrpcjson chore: extend the format checking via openrpcjson Nov 21, 2024
Copy link

github-actions bot commented Nov 21, 2024

Test Results

 22 files   -   5  328 suites   - 94   49m 14s ⏱️ - 28m 19s
608 tests  -   4  601 ✅ + 12  4 💤 ±0  3 ❌  - 16 
802 runs   - 285  793 ✅  - 262  5 💤  - 4  4 ❌  - 19 

For more details on these failures, see this check.

Results for commit fde1e08. ± Comparison against base commit d7f1bdc.

This pull request removes 5 and adds 1 tests. Note that renamed tests count towards both.
"before all" hook for "emits an approval event" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender has enough allowance "before all" hook for "emits an approval event"
"before all" hook for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests HTS token should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender does not have enough allowance when the token owner has enough balance "before all" hook for "reverts"
"before all" hook in "Debug API Test Suite" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-3 RPC Server Acceptance Tests Debug API Test Suite "before all" hook in "Debug API Test Suite"
"before each" hook for "should execute "eth_getStorageAt" request to get current state changes" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests "before each" hook for "should execute "eth_getStorageAt" request to get current state changes"
"before each" hook: reducing balance for "reverts" ‑ RPC Server Acceptance Tests Acceptance tests @erc20 Acceptance Tests ERC20 Contract should behave like erc20 transfer from when the token owner is not the zero address when the recipient is not the zero address when the spender does not have enough allowance when the token owner does not have enough balance "before each" hook: reducing balance for "reverts"
"before all" hook for "should execute "eth_getCode" for hts token" ‑ RPC Server Acceptance Tests Acceptance tests @api-batch-2 RPC Server Acceptance Tests eth_getCode "before all" hook for "should execute "eth_getCode" for hts token"

♻️ This comment has been updated with latest results.

quiet-node
quiet-node previously approved these changes Nov 21, 2024
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM some QQs

docs/openrpc.json Show resolved Hide resolved
docs/openrpc.json Show resolved Hide resolved
Signed-off-by: Nadezhda Popova <nadezhda.popova@limechain.tech>
@nadezhdapopovaa nadezhdapopovaa added internal For changes that affect the project's internal workings but not its outward-facing functionality. and removed enhancement New feature or request labels Nov 21, 2024
Copy link
Collaborator

@konstantinabl konstantinabl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! just a small nit/question

@konstantinabl konstantinabl requested review from quiet-node and a team and removed request for a team November 25, 2024 16:15
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, some questions

docs/openrpc.json Outdated Show resolved Hide resolved
docs/openrpc.json Show resolved Hide resolved
@quiet-node quiet-node modified the milestones: 0.61.0, 0.62.0 Nov 26, 2024
@nadezhdapopovaa nadezhdapopovaa force-pushed the 2728-extend-the-format-checking-via-openrpcjson branch from 19b172a to 7e262fb Compare November 27, 2024 09:00
Signed-off-by: Nadezhda Popova <nadezhda.popova@limechain.tech>
@nadezhdapopovaa nadezhdapopovaa force-pushed the 2728-extend-the-format-checking-via-openrpcjson branch from 7e262fb to d1d1fa4 Compare November 27, 2024 11:50
Signed-off-by: Nadezhda Popova <nadezhda.popova@limechain.tech>
@nadezhdapopovaa nadezhdapopovaa force-pushed the 2728-extend-the-format-checking-via-openrpcjson branch from 07e817e to fde1e08 Compare November 27, 2024 13:15
Copy link

sonarcloud bot commented Nov 27, 2024

@nadezhdapopovaa nadezhdapopovaa merged commit 1551da6 into main Nov 29, 2024
44 of 46 checks passed
@nadezhdapopovaa nadezhdapopovaa deleted the 2728-extend-the-format-checking-via-openrpcjson branch November 29, 2024 09:04
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.87%. Comparing base (967270f) to head (fde1e08).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3285      +/-   ##
==========================================
+ Coverage   77.84%   77.87%   +0.02%     
==========================================
  Files          66       69       +3     
  Lines        4460     4637     +177     
  Branches     1000     1042      +42     
==========================================
+ Hits         3472     3611     +139     
- Misses        613      662      +49     
+ Partials      375      364      -11     
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 78.67% <ø> (+0.09%) ⬆️
server 83.28% <ø> (ø)
ws-server 36.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal For changes that affect the project's internal workings but not its outward-facing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend the format checking via openrpc.json
5 participants