-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: extend the format checking via openrpcjson #3285
chore: extend the format checking via openrpcjson #3285
Conversation
Signed-off-by: Nadezhda Popova <nadezhda.popova@limechain.tech>
Signed-off-by: Nadezhda Popova <nadezhda.popova@limechain.tech>
Test Results 22 files - 5 328 suites - 94 49m 14s ⏱️ - 28m 19s For more details on these failures, see this check. Results for commit fde1e08. ± Comparison against base commit d7f1bdc. This pull request removes 5 and adds 1 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM some QQs
Signed-off-by: Nadezhda Popova <nadezhda.popova@limechain.tech>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! just a small nit/question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, some questions
19b172a
to
7e262fb
Compare
Signed-off-by: Nadezhda Popova <nadezhda.popova@limechain.tech>
7e262fb
to
d1d1fa4
Compare
Signed-off-by: Nadezhda Popova <nadezhda.popova@limechain.tech>
07e817e
to
fde1e08
Compare
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3285 +/- ##
==========================================
+ Coverage 77.84% 77.87% +0.02%
==========================================
Files 66 69 +3
Lines 4460 4637 +177
Branches 1000 1042 +42
==========================================
+ Hits 3472 3611 +139
- Misses 613 662 +49
+ Partials 375 364 -11
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description:
Related issue(s):
Fixes #2728
Checklist