Query mirror node for deployed_bytecode in eth_getCode #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Ivo-Yankov
changed the title
Ivo-Yankov
changed the title
Nana-EC
requested review from
Nana-EC,
natanasow,
shemnon,
ar-conmit and
lukelee-sl
Nana-EC
requested changes
Aug 4, 2022
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #418 +/- ##
==========================================
+ Coverage 73.55% 73.65% +0.09%
==========================================
Files 10 10
Lines 832 835 +3
Branches 136 137 +1
==========================================
+ Hits 612 615 +3
Misses 172 172
Partials 48 48
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
eth_getCodemakes a request to the mirror node. In the case of an empty result (0x) or if the contract has not yet been propagated to the mirror node the bytecode is retrieved from consensus.Related issue(s):
Fixes #27
Notes for reviewer:
Checklist