Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acceptance test support for hts precompile #424

Merged
merged 11 commits into from
Aug 10, 2022

Conversation

natanasow
Copy link
Collaborator

Signed-off-by: nikolay n.atanasow94@gmail.com

Description:

Related issue(s):

Fixes #398

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: nikolay <n.atanasow94@gmail.com>
@natanasow natanasow marked this pull request as draft August 5, 2022 14:11
Signed-off-by: nikolay <n.atanasow94@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2022

Codecov Report

Merging #424 (20a80d1) into main (06e89ee) will increase coverage by 2.47%.
The diff coverage is 83.47%.

❗ Current head 20a80d1 differs from pull request most recent head 5627596. Consider uploading reports for the commit 5627596 to get more accurate results

@@            Coverage Diff             @@
##             main     #424      +/-   ##
==========================================
+ Coverage   73.65%   76.12%   +2.47%     
==========================================
  Files          10       11       +1     
  Lines         835      909      +74     
  Branches      137      142       +5     
==========================================
+ Hits          615      692      +77     
+ Misses        172      165       -7     
- Partials       48       52       +4     
Impacted Files Coverage Δ
packages/relay/src/lib/constants.ts 100.00% <ø> (ø)
packages/relay/src/lib/errors/JsonRpcError.ts 85.71% <ø> (ø)
packages/relay/src/lib/clients/sdkClient.ts 8.18% <4.54%> (+0.63%) ⬆️
packages/relay/src/formatters.ts 66.66% <75.00%> (ø)
packages/relay/src/lib/eth.ts 84.10% <91.27%> (+2.85%) ⬆️
packages/relay/src/lib/precheck.ts 90.14% <94.73%> (+0.74%) ⬆️
packages/relay/src/lib/clients/mirrorNodeClient.ts 90.14% <100.00%> (+4.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: nikolay <n.atanasow94@gmail.com>
@natanasow natanasow marked this pull request as ready for review August 8, 2022 07:31
@natanasow natanasow self-assigned this Aug 8, 2022
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Copy link
Collaborator

@Ivo-Yankov Ivo-Yankov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a small nit.

packages/server/tests/acceptance/htsPrecompile.spec.ts Outdated Show resolved Hide resolved
Signed-off-by: nikolay <n.atanasow94@gmail.com>
@Nana-EC Nana-EC added enhancement New feature or request limechain P1 labels Aug 8, 2022
@Nana-EC Nana-EC added this to the 0.6.0 milestone Aug 8, 2022
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
Waiting on reduction in initial hbar balance funded to test accounts.

packages/server/tests/acceptance/htsPrecompile.spec.ts Outdated Show resolved Hide resolved
packages/server/tests/acceptance/htsPrecompile.spec.ts Outdated Show resolved Hide resolved
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
@natanasow natanasow requested a review from Nana-EC August 9, 2022 13:32
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Just move the contract deployments (baseHTSContract and HTSTokenContract into the before to assure no tests run if it fails and that tests have it available prior to run

Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@natanasow natanasow merged commit a66f3df into main Aug 10, 2022
@natanasow natanasow deleted the 398-add-acceptance-test-support-for-hts-precompile branch August 10, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request limechain P1
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add acceptance test support for HederaTokenService precompile
4 participants