-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acceptance test support for hts precompile #424
Add acceptance test support for hts precompile #424
Conversation
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #424 +/- ##
==========================================
+ Coverage 73.65% 76.12% +2.47%
==========================================
Files 10 11 +1
Lines 835 909 +74
Branches 137 142 +5
==========================================
+ Hits 615 692 +77
+ Misses 172 165 -7
- Partials 48 52 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a small nit.
Signed-off-by: nikolay <n.atanasow94@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Waiting on reduction in initial hbar balance funded to test accounts.
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG. Just move the contract deployments (baseHTSContract
and HTSTokenContract
into the before to assure no tests run if it fails and that tests have it available prior to run
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: nikolay n.atanasow94@gmail.com
Description:
Related issue(s):
Fixes #398
Notes for reviewer:
Checklist