test: Acceptance tests seems inconsistent #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgi-l95
requested review from
Ivo-Yankov,
Daniel-K-Ivanov,
natanasow and
Nana-EC
Nana-EC
requested changes
Aug 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #430 +/- ##
==========================================
+ Coverage 73.55% 73.65% +0.09%
==========================================
Files 10 10
Lines 832 835 +3
Branches 136 137 +1
==========================================
+ Hits 612 615 +3
Misses 172 172
Partials 48 48
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Nana-EC
previously approved these changes
Aug 9, 2022
georgi-l95
force-pushed
the
381-inconsistent-acceptancetest
branch
from
00a10db to
78832c2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixing two tests with these changes. Another one was fixed here hashgraph/hedera-sdk-js#1224.
Logic behind fix for test:
should call eth_feeHistory with updated feesIn the before hook, we are feeding default fees to the mirror node. So that we know how many blocks we should take and where to expect those fees. But if there is discrepancy in the blocks, the first element in this array is taken from the consensus node, not from the mirror node. This is the reason sometimes this value in the first index is wrong.
Logic behind fix for test:
should call eth_feeHistory with newest block > latestBy the time we're requesting the last block, it's already ahead by one. So we were excepting it to be 10 ahead, but it's actually 11 ahead on rare occasions.
Related issue(s):
Fixes #381
Notes for reviewer:
Checklist