Resolve issues with some fields in eth_getBlock #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Codecov Report
@@ Coverage Diff @@
## main #432 +/- ##
==========================================
- Coverage 76.23% 76.12% -0.11%
==========================================
Files 11 11
Lines 913 909 -4
Branches 144 142 -2
==========================================
- Hits 696 692 -4
Misses 165 165
Partials 52 52
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Ivo-Yankov
added
bug
Daniel-K-Ivanov
previously approved these changes
Aug 9, 2022
9 tasks
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Ivo-Yankov
dismissed stale reviews from Daniel-K-Ivanov and Nana-EC
via
83487d3
# Conflicts: # packages/relay/src/lib/eth.ts
|
Kudos, SonarCloud Quality Gate passed!
|
natanasow
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix issues with values returned from
getBlocks:timestampandgasLimit.timestamplogic to be always the start of the period, returned by the mirror node at/api/v1/blocks/:hashOrNumbergasLimitto be hardcoded as 15000000gas_usedfield from/api/v1/blocks/:hashOrNumberasgasUsedinstead of calculating the gas sum of all contract results in the block.Related issue(s):
Fixes an issue, described in a comment in 414#issuecomment-1207980112
Notes for reviewer:
Checklist