Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump 0.6.0-rc1 #444

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Bump 0.6.0-rc1 #444

merged 3 commits into from
Aug 17, 2022

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Aug 16, 2022

Signed-off-by: Nana-EC nana@swirldslabs.com

Description:

  • Bump 0.6.0-rc1
  • Add waits in acceptance tests to make sure mirror node has account info

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Nana-EC <nana@swirldslabs.com>
@Nana-EC Nana-EC self-assigned this Aug 16, 2022
@Nana-EC Nana-EC added enhancement New feature or request P1 process Build, test and deployment-process related tasks labels Aug 16, 2022
@Nana-EC Nana-EC modified the milestones: 0.7.0, 0.6.0 Aug 16, 2022
@Nana-EC Nana-EC requested review from lukelee-sl and shemnon August 16, 2022 13:52
@Nana-EC Nana-EC marked this pull request as ready for review August 16, 2022 13:52
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #444 (eff8ade) into release/0.6 (5f6b816) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           release/0.6     #444   +/-   ##
============================================
  Coverage        76.38%   76.38%           
============================================
  Files               12       12           
  Lines              919      919           
  Branches           142      142           
============================================
  Hits               702      702           
  Misses             165      165           
  Partials            52       52           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

shemnon
shemnon previously approved these changes Aug 16, 2022
Signed-off-by: Nana-EC <nana@swirldslabs.com>
Signed-off-by: Nana-EC <nana@swirldslabs.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nana-EC Nana-EC requested a review from shemnon August 17, 2022 02:08
@shemnon
Copy link
Contributor

shemnon commented Aug 17, 2022

looks like 91afc68 and eff8ade were merged in, which are both out of scope for a version bump pr.

@Nana-EC
Copy link
Collaborator Author

Nana-EC commented Aug 17, 2022

looks like 91afc68 and eff8ade were merged in, which are both out of scope for a version bump pr.

Agreed, expect PR was blocked for over a day with multiple retries and failures on acceptance tests.
Those fixes were to unblock this PR.
Also added them into main so this is sort of an early cherry pick. See
https://github.com/hashgraph/hedera-json-rpc-relay/pull/447/files/27c7b4d4b6dd108ffaf30122fb908e40687a838b..797919764f785dbbcd03b905d82ed5212ad4ede0

@Nana-EC Nana-EC merged commit d884d3b into release/0.6 Aug 17, 2022
@Nana-EC Nana-EC deleted the bump-0-6-0-rc1 branch August 17, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 process Build, test and deployment-process related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants