Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for HBAR Rate limit #584

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Conversation

georgi-l95
Copy link
Collaborator

@georgi-l95 georgi-l95 commented Oct 4, 2022

Description:

  • Adds unit tests with 100% coverage for new HBAR Rate Limit functionality
  • Move all rate limit acceptance tests in one file

Related issue(s):

Fixes #582

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 linked an issue Oct 4, 2022 that may be closed by this pull request
@georgi-l95 georgi-l95 self-assigned this Oct 4, 2022
@georgi-l95 georgi-l95 added enhancement New feature or request limechain labels Oct 4, 2022
@georgi-l95 georgi-l95 added this to the 0.10 milestone Oct 4, 2022
@georgi-l95 georgi-l95 marked this pull request as ready for review October 4, 2022 09:44
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 69.14% // Head: 70.58% // Increases project coverage by +1.44% 🎉

Coverage data is based on head (9b284ee) compared to base (466adc6).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #584      +/-   ##
==========================================
+ Coverage   69.14%   70.58%   +1.44%     
==========================================
  Files          16       16              
  Lines        1076     1088      +12     
  Branches      182      184       +2     
==========================================
+ Hits          744      768      +24     
+ Misses        281      269      -12     
  Partials       51       51              
Impacted Files Coverage Δ
packages/relay/src/lib/clients/sdkClient.ts 6.83% <0.00%> (-0.09%) ⬇️
packages/relay/src/lib/hbarlimiter/index.ts 100.00% <100.00%> (+82.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nana-EC Nana-EC added the P2 label Oct 4, 2022
@georgi-l95 georgi-l95 merged commit 38a5f77 into main Oct 4, 2022
@georgi-l95 georgi-l95 deleted the 582-unit-tests-for-hbar-rate-limit branch October 4, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request limechain P2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests for HBAR Rate limit
3 participants