Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Acceptance Tests and Dapp Test workaround #589

Merged
merged 26 commits into from
Oct 7, 2022
Merged

Remove Acceptance Tests and Dapp Test workaround #589

merged 26 commits into from
Oct 7, 2022

Conversation

georgi-l95
Copy link
Collaborator

@georgi-l95 georgi-l95 commented Oct 5, 2022 •
edited by Nana-EC
Loading

Signed-off-by: georgi-l95 glazarov95@gmail.com

Description:

  • Remove workaround for both Acceptance Tests and Dapp tests.
  • Remove dapp example delay in bootstrap script, which waits for 20 seconds. Now it checks every 10 seconds if the node has started.
  • Added slight delay of 3 sec in hardhat example test case, because often it's too fast when querying the new balance, which result in the sam amount as before transfer transaction.

Related issue(s):

Fixes #507
Fixes #366

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@georgi-l95
test with newest package
79f4d23 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 linked an issue Oct 5, 2022 that may be closed by this pull request
Remove local node workaround for dapp and acceptance tests #507
Closed
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022 •
edited
Loading

Codecov Report

Base: 71.39% // Head: 70.66% // Decreases project coverage by -0.72% ⚠️

Coverage data is based on head (083f891) compared to base (54bb7d4).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
- Coverage   71.39%   70.66%   -0.73%     
==========================================
  Files          16       16              
  Lines        1115     1125      +10     
  Branches      192      191       -1     
==========================================
- Hits          796      795       -1     
- Misses        267      279      +12     
+ Partials       52       51       -1
Impacted Files Coverage Δ
packages/relay/src/lib/clients/sdkClient.ts 6.28% <0.00%> (-0.55%) ⬇️
packages/relay/src/lib/eth.ts 84.18% <0.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@georgi-l95
test
5e1d8c8 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
chain id change
3d47db2 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
test
f4b6afc 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
test
ab2fc28 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
test
97bfa3d 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
x
ed5bd19 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
use latest images
c7be4fa 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 changed the title test Remove acceptancetest and dapp test workaround - WIP Testing Oct 5, 2022
@georgi-l95
test
ab0b69d 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
x
d695e83 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
change workaround in acceptancetest
df5bbf5 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
x
a0c8629 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
bump hedera-local version
3e37b92 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
x
ff04a9c 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
test
793ded7 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 self-assigned this Oct 6, 2022
@georgi-l95
add dapp-example local node check
cf92192 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
fix
1f1f65a 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
fix invalid variable
106d96d 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
x
81d4100 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
bump hardhat example delay
a7fc586 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 added enhancement New feature or request limechain labels Oct 6, 2022
@georgi-l95 georgi-l95 marked this pull request as ready for review October 6, 2022 08:08
@georgi-l95 georgi-l95 changed the title Remove acceptancetest and dapp test workaround - WIP Testing Remove Acceptance Tests and Dapp Test workaround Oct 6, 2022
@georgi-l95
remove delay
0e83af3 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@Nana-EC Nana-EC added this to the 0.10 milestone Oct 6, 2022
Nana-EC
Nana-EC requested changes Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.
Missing a catch for a case where the node never starts up

dapp-example/tests/support/bootstrap.js Outdated Show resolved Hide resolved
@georgi-l95
test not starting node
87645f4 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
x
08d073c 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
x
f889a7d 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
083f891 
x
@georgi-l95
case if the node is not started
476eb69 
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@georgi-l95 georgi-l95 requested a review from Nana-EC October 7, 2022 11:29
Nana-EC
Nana-EC approved these changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@georgi-l95 georgi-l95 merged commit 20b1b88 into main Oct 7, 2022
@georgi-l95 georgi-l95 deleted the 507-remove-local-node-workaround-for-dapp-and-acceptance-tests branch October 7, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nana-EC Nana-EC Nana-EC approved these changes

@natanasow natanasow Awaiting requested review from natanasow

@dimitrovmaksim dimitrovmaksim Awaiting requested review from dimitrovmaksim

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov Ivo-Yankov is a code owner

@lukelee-sl lukelee-sl Awaiting requested review from lukelee-sl

Assignees

@georgi-l95 georgi-l95

Labels
enhancement New feature or request limechain
Projects
Smart Contract Sprint Board
Archived in project
Milestone
0.10.0
3 participants
@georgi-l95 @codecov-commenter @Nana-EC