eth_getCode to return the redirect bytecode for HTS tokens
#598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Codecov ReportBase: 71.39% // Head: 70.85% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #598 +/- ##
==========================================
- Coverage 71.39% 70.85% -0.54%
==========================================
Files 16 16
Lines 1115 1139 +24
Branches 192 195 +3
==========================================
+ Hits 796 807 +11
- Misses 267 280 +13
Partials 52 52
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
georgi-l95
requested review from
Nana-EC,
Ivo-Yankov,
dimitrovmaksim,
lukelee-sl,
natanasow and
shemnon
Nana-EC
requested changes
Oct 7, 2022
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
georgi-l95
deleted the
594-eth_getcode-to-return-the-redirect-bytecode-for-hts-tokens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
resolveEntityTypefunction in mirror node to support token typeseth_getCode- check for address type, if it's HTS token return redirect bytecode, rest is the same as beforeaddresstotokenIdconversion by usingparseInt(address, 16)Related issue(s):
Fixes #594
Fixes #583
Notes for reviewer:
Little change in unit tests, as we are making some additional requests and we need to mock them.
Checklist