Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle null gas_used from contract results #610

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Handle null gas_used from contract results #610

merged 1 commit into from
Oct 12, 2022

Conversation

dimitrovmaksim
Copy link
Collaborator

Signed-off-by: Maksim Dimitrov dimitrov.maksim@gmail.com

Description:
Return 0x0 when contract result query returns null for gas_used

Related issue(s):

Fixes #606

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@dimitrovmaksim
Handle null gas used from contract results
aaa0ecf 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim dimitrovmaksim added bug Something isn't working limechain labels Oct 11, 2022
@dimitrovmaksim dimitrovmaksim self-assigned this Oct 11, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nana-EC Nana-EC requested a review from lukelee-sl October 11, 2022 14:40
Nana-EC
Nana-EC approved these changes Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@Nana-EC Nana-EC added this to the 0.10 milestone Oct 11, 2022
@dimitrovmaksim dimitrovmaksim changed the title Handle null gas used from contract results Handle null gas_used from contract results Oct 11, 2022
@dimitrovmaksim dimitrovmaksim merged commit 3cb329b into main Oct 12, 2022
@dimitrovmaksim dimitrovmaksim deleted the 606-handle-null-gas-used branch October 12, 2022 06:32
@dimitrovmaksim dimitrovmaksim mentioned this pull request Oct 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukelee-sl lukelee-sl lukelee-sl approved these changes

@Nana-EC Nana-EC Nana-EC approved these changes

@georgi-l95 georgi-l95 Awaiting requested review from georgi-l95

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov

@natanasow natanasow Awaiting requested review from natanasow

Assignees

@dimitrovmaksim dimitrovmaksim

Labels
bug Something isn't working limechain
Projects
Smart Contract Sprint Board
Archived in project
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

Relay can't handle null gas_used
3 participants
@dimitrovmaksim @Nana-EC @lukelee-sl