Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging and metrics to rate limit logic #622

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Oct 15, 2022

Description:
Add logging and metrics to rate limit logic

  • Add log to user method limit
  • Add log to budget limit
  • Add metric to method limit
  • Capture methodName in user method limit

Related issue(s):

Fixes #621

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@Nana-EC Nana-EC added enhancement New feature or request P2 labels Oct 15, 2022
@Nana-EC Nana-EC added this to the 0.10 milestone Oct 15, 2022
@Nana-EC Nana-EC self-assigned this Oct 15, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 70.74% // Head: 69.27% // Decreases project coverage by -1.47% ⚠️

Coverage data is based on head (fac4e4f) compared to base (fa98536).
Patch coverage: 16.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   70.74%   69.27%   -1.48%     
==========================================
  Files          16       16              
  Lines        1135     1139       +4     
  Branches      195      195              
==========================================
- Hits          803      789      -14     
- Misses        279      294      +15     
- Partials       53       56       +3     
Impacted Files Coverage Δ
packages/relay/src/lib/clients/sdkClient.ts 6.21% <0.00%> (ø)
packages/relay/src/lib/hbarlimiter/index.ts 41.93% <20.00%> (-58.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
@Nana-EC Nana-EC force-pushed the 621-rate-limit-logs-metrics branch from fac4e4f to 775aae5 Compare October 17, 2022 06:11
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nana-EC Nana-EC merged commit 8460b55 into main Oct 17, 2022
@Nana-EC Nana-EC deleted the 621-rate-limit-logs-metrics branch October 17, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add logging and metrics to rate limit logic
3 participants