Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a HTS token association example to DApp example #647

Merged

Conversation

natanasow
Copy link
Collaborator

Signed-off-by: nikolay n.atanasow94@gmail.com

Description:

Related issue(s):

Fixes #620

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: nikolay <n.atanasow94@gmail.com>
@natanasow natanasow marked this pull request as draft October 20, 2022 13:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Base: 70.85% // Head: 70.90% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (6965309) compared to base (8460b55).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
+ Coverage   70.85%   70.90%   +0.05%     
==========================================
  Files          16       16              
  Lines        1139     1148       +9     
  Branches      195      198       +3     
==========================================
+ Hits          807      814       +7     
- Misses        279      280       +1     
- Partials       53       54       +1     
Impacted Files Coverage Δ
packages/relay/src/lib/errors/JsonRpcError.ts 71.42% <0.00%> (-5.50%) ⬇️
packages/relay/src/lib/eth.ts 83.30% <0.00%> (+0.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: nikolay <n.atanasow94@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@natanasow natanasow marked this pull request as ready for review October 21, 2022 07:31
@natanasow natanasow self-assigned this Oct 21, 2022
Copy link
Collaborator

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've ran the tests locally. Works fine.

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@natanasow natanasow merged commit 1769a21 into main Oct 24, 2022
@natanasow natanasow deleted the 620-add-a-hts-token-association-example-to-dapp-example branch October 24, 2022 06:40
@Nana-EC Nana-EC added this to the 0.11.0 milestone Oct 25, 2022
@Nana-EC Nana-EC added enhancement New feature or request P1 labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add a HTS token association example to DApp example
4 participants