Add intermittent gasPrice Buffer Logic #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Nana-EC
requested review from
shemnon,
Ivo-Yankov,
natanasow,
ar-conmit and
lukelee-sl
georgi-l95
previously approved these changes
Nov 13, 2022
There was a problem hiding this comment.
LGTM! nit: It might be a good idea to add this new variable to README.md
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportBase: 70.87% // Head: 70.88% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #690 +/- ##
==========================================
+ Coverage 70.87% 70.88% +0.01%
==========================================
Files 16 16
Lines 1188 1192 +4
Branches 214 216 +2
==========================================
+ Hits 842 845 +3
Misses 286 286
- Partials 60 61 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nana Essilfie-Conduah nana@swirldslabs.com
Description:
During long lived operations of the relay it's possible for the relay to observe a change int eh gasPrice calculation needed by submitted transactions.
As a result some checks are often 1 tiny bar off
Related issue(s):
Fixes #678
Notes for reviewer:
Checklist