Add logic to handle missing transaction index #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Nana-EC
requested review from
shemnon,
georgi-l95,
dimitrovmaksim,
ar-conmit and
lukelee-sl
Codecov ReportBase: 70.87% // Head: 70.95% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
==========================================
+ Coverage 70.87% 70.95% +0.08%
==========================================
Files 16 16
Lines 1188 1188
Branches 214 214
==========================================
+ Hits 842 843 +1
Misses 286 286
+ Partials 60 59 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Nana-EC
dismissed stale reviews from georgi-l95 and dimitrovmaksim
via
850bff3
|
Kudos, SonarCloud Quality Gate passed!
|
dimitrovmaksim
approved these changes
Nov 14, 2022
georgi-l95
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nana Essilfie-Conduah nana@swirldslabs.com
Description:
It seems occasionally
transaction_indexcan be undefined from mirror node.Currently the relay throws errors in this case.
While we figure out why
Related issue(s):
Fixes #692
Notes for reviewer:
Checklist