-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config support for SDK transport security #741
Add config support for SDK transport security #741
Conversation
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Codecov ReportBase: 72.53% // Head: 72.47% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
==========================================
- Coverage 72.53% 72.47% -0.06%
==========================================
Files 16 16
Lines 1227 1228 +1
Branches 224 225 +1
==========================================
Hits 890 890
- Misses 279 280 +1
Partials 58 58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
Please update PR comments with something like
Update relay.ts to set transport based on value of new CLIENT_TRANSPORT_SECURITY config
Additionally, you need to expose this in the Helm charts values.yaml
and deployment.yaml
so it can be utilized
Signed-off-by: nikolay <n.atanasow94@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deployment component should be optional. Then we're good
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Signed-off-by: nikolay n.atanasow94@gmail.com
Description:
Update relay.ts to set transport based on value of new CLIENT_TRANSPORT_SECURITY config
Related issue(s):
Fixes #727
Notes for reviewer:
Checklist