Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config support for SDK transport security #741

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

natanasow
Copy link
Collaborator

@natanasow natanasow commented Dec 5, 2022

Signed-off-by: nikolay n.atanasow94@gmail.com

Description:
Update relay.ts to set transport based on value of new CLIENT_TRANSPORT_SECURITY config

Related issue(s):

Fixes #727

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: nikolay <n.atanasow94@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Base: 72.53% // Head: 72.47% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (2748820) compared to base (f9e0dc5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
- Coverage   72.53%   72.47%   -0.06%     
==========================================
  Files          16       16              
  Lines        1227     1228       +1     
  Branches      224      225       +1     
==========================================
  Hits          890      890              
- Misses        279      280       +1     
  Partials       58       58              
Impacted Files Coverage Δ
packages/relay/src/lib/relay.ts 22.50% <0.00%> (-0.58%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Nana-EC Nana-EC added enhancement New feature or request P2 process Build, test and deployment-process related tasks labels Dec 5, 2022
@Nana-EC Nana-EC added this to the 0.14.0 milestone Dec 5, 2022
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good
Please update PR comments with something like
Update relay.ts to set transport based on value of new CLIENT_TRANSPORT_SECURITY config

Additionally, you need to expose this in the Helm charts values.yaml and deployment.yaml so it can be utilized

Signed-off-by: nikolay <n.atanasow94@gmail.com>
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deployment component should be optional. Then we're good

helm-chart/templates/deployment.yaml Outdated Show resolved Hide resolved
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 requested a review from Nana-EC December 6, 2022 20:14
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@georgi-l95 georgi-l95 self-assigned this Dec 7, 2022
@georgi-l95 georgi-l95 merged commit 1da80a6 into main Dec 7, 2022
@georgi-l95 georgi-l95 deleted the 727-add-config-support-for-sdk-transport-security branch December 7, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 process Build, test and deployment-process related tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add config support for SDK transport security
4 participants