Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue490/postman testing addition #759

Merged
merged 6 commits into from
Dec 12, 2022

Conversation

rustyShacklefurd
Copy link
Contributor

@rustyShacklefurd rustyShacklefurd commented Dec 8, 2022

Description:

Related issue(s):

Fixes #490

Notes for reviewer:
Integration deployment output:

# Source: hedera-json-rpc-relay/templates/cronjob.yaml
apiVersion: batch/v1
kind: CronJob
metadata:
  name: hedera-json-rpc-relay-test
  namespace: default
spec:
  concurrencyPolicy: Allow
  schedule: 0 0 * * *
  jobTemplate:
    spec:
      backoffLimit: 2
      template:
        spec:
          serviceAccountName: integration-test-hashio-hedera-json-rpc-relay-test
          restartPolicy: Never
          initContainers:
            - name: curl-config
              image: curlimages/curl
              command:
                - curl
                - https://github.com/hashgraph/hedera-json-rpc-relay/blob/main/packages/server/tests/postman.json
                - -o
                - postman.json
              volumeMounts:
              - name: config-json
                mountPath: "/"
          containers:
            - name: newman
              image: postman/newman
              command:
                - newman
                - run
                - postman.json
                - --env-var
                - baseUrl="https://hashio-integration.hedera-devops.com/api"
              volumeMounts:
              - name: config-json
                mountPath: "/"
                readOnly: true
          volumes:
            - name: config-json
              emptyDir: {}

Checklist

  • Documented (Code comments, README, etc.)

…this setup shouldn't need any role/rolebindings as this setup will not be interacting with k8s APIs. In the future this may change if the tests are wanting to be run against each pod individually

Signed-off-by: Matt Halder <rustyShacklefurd@users.noreply.github.com>
Signed-off-by: Matt Halder <rustyShacklefurd@users.noreply.github.com>
Signed-off-by: Matt Halder <rustyShacklefurd@users.noreply.github.com>
…stead of fullname and truncated the name value

Signed-off-by: Matt Halder <rustyShacklefurd@users.noreply.github.com>
Signed-off-by: Matt Halder <rustyShacklefurd@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

Base: 71.08% // Head: 72.87% // Increases project coverage by +1.78% 🎉

Coverage data is based on head (8645e0d) compared to base (25ae55f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
+ Coverage   71.08%   72.87%   +1.78%     
==========================================
  Files          16       16              
  Lines        1207     1246      +39     
  Branches      219      231      +12     
==========================================
+ Hits          858      908      +50     
+ Misses        287      280       -7     
+ Partials       62       58       -4     
Impacted Files Coverage Δ
packages/relay/src/lib/relay.ts 22.50% <0.00%> (-0.58%) ⬇️
packages/relay/src/lib/eth.ts 83.72% <0.00%> (+0.76%) ⬆️
packages/relay/src/lib/errors/JsonRpcError.ts 75.00% <0.00%> (+6.25%) ⬆️
packages/relay/src/lib/clients/mirrorNodeClient.ts 96.23% <0.00%> (+6.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Nana-EC
Nana-EC previously approved these changes Dec 8, 2022
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

helm-chart/templates/cronjob.yaml Outdated Show resolved Hide resolved
@Nana-EC Nana-EC added enhancement New feature or request P1 process Build, test and deployment-process related tasks labels Dec 8, 2022
@Nana-EC Nana-EC added this to the 0.14.0 milestone Dec 8, 2022
Signed-off-by: Matt Halder <rustyShacklefurd@users.noreply.github.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rustyShacklefurd rustyShacklefurd merged commit a3062db into main Dec 12, 2022
@rustyShacklefurd rustyShacklefurd deleted the issue490/postman-testing-addition branch December 12, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1 process Build, test and deployment-process related tasks
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add Postman Testing to helm chart
3 participants