-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue490/postman testing addition #759
Conversation
…this setup shouldn't need any role/rolebindings as this setup will not be interacting with k8s APIs. In the future this may change if the tests are wanting to be run against each pod individually Signed-off-by: Matt Halder <rustyShacklefurd@users.noreply.github.com>
Signed-off-by: Matt Halder <rustyShacklefurd@users.noreply.github.com>
Signed-off-by: Matt Halder <rustyShacklefurd@users.noreply.github.com>
…stead of fullname and truncated the name value Signed-off-by: Matt Halder <rustyShacklefurd@users.noreply.github.com>
Signed-off-by: Matt Halder <rustyShacklefurd@users.noreply.github.com>
Codecov ReportBase: 71.08% // Head: 72.87% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
==========================================
+ Coverage 71.08% 72.87% +1.78%
==========================================
Files 16 16
Lines 1207 1246 +39
Branches 219 231 +12
==========================================
+ Hits 858 908 +50
+ Misses 287 280 -7
+ Partials 62 58 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Signed-off-by: Matt Halder <rustyShacklefurd@users.noreply.github.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Related issue(s):
Fixes #490
Notes for reviewer:
Integration deployment output:
Checklist