Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subgraph GitHub workflow and update the Readme #780

Merged
merged 22 commits into from
Dec 19, 2022
Merged

Add subgraph GitHub workflow and update the Readme #780

merged 22 commits into from
Dec 19, 2022

Conversation

dimitrovmaksim
Copy link
Collaborator

@dimitrovmaksim dimitrovmaksim commented Dec 15, 2022 •
edited
Loading

Signed-off-by: Maksim Dimitrov dimitrov.maksim@gmail.com

  1. Adds a GitHub workflow for the subgraph indexing tests
  2. Updates the readme with introduction to TheGraph, How to run a private node against testnet, previewnet and mainnet

Related issue(s):

Fixes #709
Fixes #772

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@dimitrovmaksim
First try
64b1008 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim
Generate package-lock.json. Update workflow
23a0459 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim
Try to set default working dir
dcc4368 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim dimitrovmaksim changed the title First try Subgraph github workflow Dec 15, 2022
@dimitrovmaksim
Add create .env file step
9c49a48 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim
Run hedera-local in detached
297e99e 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim
Update packages and workflow
40683c0 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim dimitrovmaksim force-pushed the 709-github-workflow-for-subgraph-tests branch from 3dec13f to 40683c0 Compare December 15, 2022 15:34
@dimitrovmaksim
Add sleep step
abf1133 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim
Change npx to npm
d19795c 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim
Remove step
94c7e6e 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022 •
edited
Loading

Codecov Report

Base: 72.89% // Head: 72.85% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (e7dcf1c) compared to base (12b4fd0).
Patch coverage: 75.00% of modified lines in pull request are covered.

❗ Current head e7dcf1c differs from pull request most recent head bed0da8. Consider uploading reports for the commit bed0da8 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
- Coverage   72.89%   72.85%   -0.04%     
==========================================
  Files          16       16              
  Lines        1247     1249       +2     
  Branches      232      234       +2     
==========================================
+ Hits          909      910       +1     
  Misses        280      280              
- Partials       58       59       +1
Impacted Files Coverage Δ
packages/relay/src/lib/eth.ts 83.62% <75.00%> (-0.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dimitrovmaksim
Try without retry
22c0a18 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim
Try without retry v2
074f7c6 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim
Try without retry v3
632c7aa 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim
Add loadash.isequal
fb5e92c 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim
Use lodash
45ab917 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim
Load isEqual from lodash
afef611 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim
Use npm ci
8c36f52 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim
Fix typo
877c4bd 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim
Reduce the wait time, update the readme
e670524 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim dimitrovmaksim changed the title Subgraph github workflow Add subgraph GitHub workflow and update the Readme Dec 16, 2022
@dimitrovmaksim dimitrovmaksim self-assigned this Dec 16, 2022
@dimitrovmaksim dimitrovmaksim added the enhancement New feature or request label Dec 16, 2022
@dimitrovmaksim
Update Readme
610be03 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim
More Readme updates
0733d4a 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim
Update Readme again
be04105 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim dimitrovmaksim marked this pull request as ready for review December 16, 2022 10:46
georgi-l95
georgi-l95 previously approved these changes Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lukelee-sl
lukelee-sl reviewed Dec 19, 2022
View reviewed changes
tools/subgraph-example/README.md Outdated

## Try it out:

### Prerequisites:

Note: Currently this example needs to be executed against older relay and mirror-node versions, until all fixes have been released.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we specify which versions work?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the readme and added a link to the full custom local-node config

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you

@dimitrovmaksim
Update relay and mirror-node version in readme
bed0da8 
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

lukelee-sl
lukelee-sl approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

georgi-l95
georgi-l95 approved these changes Dec 19, 2022
View reviewed changes
Copy link
Collaborator

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@lukelee-sl lukelee-sl added this to the 0.14.0 milestone Dec 19, 2022
@dimitrovmaksim dimitrovmaksim merged commit 9e18be6 into main Dec 19, 2022
@dimitrovmaksim dimitrovmaksim deleted the 709-github-workflow-for-subgraph-tests branch December 19, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukelee-sl lukelee-sl lukelee-sl approved these changes

@georgi-l95 georgi-l95 georgi-l95 approved these changes

@Nana-EC Nana-EC Awaiting requested review from Nana-EC

Assignees

@dimitrovmaksim dimitrovmaksim

Labels
enhancement New feature or request
Projects
Smart Contract Sprint Board
Archived in project
Milestone
0.14.0
4 participants
@dimitrovmaksim @codecov-commenter @georgi-l95 @lukelee-sl