Optimize acceptance test CI #804
Conversation
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Ivo-Yankov
changed the title
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Codecov ReportBase: 73.76% // Head: 73.76% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
=======================================
Coverage 73.76% 73.76%
=======================================
Files 29 29
Lines 1776 1776
Branches 324 324
=======================================
Hits 1310 1310
Misses 372 372
Partials 94 94 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
The settings of the |
Ivo-Yankov
requested review from
Nana-EC,
ar-conmit,
georgi-l95,
lukelee-sl and
natanasow
| const query = new FileContentsQuery() | ||
| .setFileId(fileId); | ||
|
|
||
| const data = await query.execute(this.client); |
There was a problem hiding this comment.
nit: we can skip the variable assignment return await query.execute(this.client)
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
# Conflicts: # packages/server/tests/acceptance/rpc_chunk1.spec.ts
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
.github/workflows/acceptance.yml
Outdated
| @@ -8,11 +8,23 @@ on: | |||
| tags: [v*] | |||
|
|
|||
| jobs: | |||
| api: | |||
| name: API | |||
| api_chunk_1: | |||
There was a problem hiding this comment.
Do the chunks have any logic to the grouping?
If so let's name it appropriately.
If not maybe api_batch_1 etc is better.
There was a problem hiding this comment.
There isn't any speciffic logic to the grouping. I changed it from chunk to batch.
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
.github/workflows/acceptance.yml
Outdated
| api: | ||
| name: API | ||
| api_batch_1: | ||
| name: API Chunk 1 |
There was a problem hiding this comment.
nit: here and 2 below
| name: API Chunk 1 | |
| name: API Batch 1 |
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
# Conflicts: # packages/server/tests/acceptance/rpc_batch1.spec.ts
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
Signed-off-by: Ivo Yankov <ivo@devlabs.bg>
|
Kudos, SonarCloud Quality Gate passed!
|
Nana-EC
added
enhancement
Description:
The Acceptance API CI takes up to 40 minutes to complete. This PR splits it into 3 smaller chunks to reduce the execution time.
Related issue(s):
Fixes #
Notes for reviewer:
Checklist