Fix eth_estimateGas for hollow account creation (#844) #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is the DCO Check failing with: one commit is incorrectly signed off, when the commit in this PR has "Signed-off-by" as part of the message, could it be because it was expecting that at the last line of the commit message, and in this case is "Co-authored-by" instead?
|
Hollow account creation requires an accurate gas amount response - add a `TX_HOLLOW_ACCOUNT_CREATION_GAS` to capture the necessary gas amount - Update `eth_estimateGas` to check in the case of a transfer transaction if the recipient exists or not. If so return update gas, if not default to current flow - Update unit and acceptance tests Signed-off-by: nikolay <n.atanasow94@gmail.com> Signed-off-by: georgi-l95 <glazarov95@gmail.com> Co-authored-by: georgi-l95 <glazarov95@gmail.com> Signed-off-by: Nana Essilfie-Conduah <nana@swirldslabs.com>
Nana-EC
force-pushed
the
0-17-fix-estimateGas-for-hollow-account-creation
branch
from
5e6e672 to
d0a5d29
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
lukelee-sl
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cherry pick #844
Hollow account creation requires an accurate gas amount response
TX_HOLLOW_ACCOUNT_CREATION_GASto capture the necessary gas amounteth_estimateGasto check in the case of a transfer transaction if the recipient exists or not. If so return update gas, if not default to current flowSigned-off-by: nikolay n.atanasow94@gmail.com
Signed-off-by: georgi-l95 glazarov95@gmail.com
Co-authored-by: georgi-l95 glazarov95@gmail.com
Related issue(s):
Fixes #
Notes for reviewer:
Checklist