Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Hedera Mirror Node Rest Java container #791

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

georgi-l95
Copy link
Collaborator

Description:
This PR aims to add the new mirror node java rest module as a docker container, with the following changes:

  • Setups up the docker-compose file to include this new container.
  • Setup application.yml to include the needed variables for the rest-java module.

Related issue(s):

Fixes #790

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 linked an issue Oct 8, 2024 that may be closed by this pull request
@georgi-l95 georgi-l95 added Improvement Code changes driven by non business requirements. Docker Feature that impacts docker labels Oct 8, 2024
Copy link

sonarcloud bot commented Oct 8, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.59%. Comparing base (5682eca) to head (b51b4ba).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
- Coverage   59.58%   57.59%   -2.00%     
==========================================
  Files          30       30              
  Lines        1403     1403              
  Branches      173      173              
==========================================
- Hits          836      808      -28     
- Misses        566      574       +8     
- Partials        1       21      +20     

see 13 files with indirect coverage changes

Impacted file tree graph

@georgi-l95 georgi-l95 changed the title feat:add rest java container feat: Add Hedera Mirror Node Rest Java container Oct 8, 2024
@georgi-l95 georgi-l95 marked this pull request as ready for review November 28, 2024 09:04
@georgi-l95 georgi-l95 self-assigned this Nov 28, 2024
@georgi-l95 georgi-l95 merged commit 105a5ba into main Nov 28, 2024
14 of 15 checks passed
@georgi-l95 georgi-l95 deleted the 790-add-mirror-node-java-rest-container branch November 28, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker Feature that impacts docker Improvement Code changes driven by non business requirements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Mirror Node Java Rest Container
4 participants