Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve understanding of "Payer Account" by adding "Sender Account" field #629

Closed
bguiz opened this issue Jun 7, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@bguiz
Copy link

bguiz commented Jun 7, 2023

Problem

  • UI is confusing because it displays "Payer Account" on a transaction page, but does not display the account that signed the transaction
  • Note that the signer account is displayed linked within the page, but in non-obvious placed
    • Under "Transfers > Fee transfers", the account that sends to "Hedera fee collection account"
    • Under "Call Trace", the "from" field
  • This isn't intuitive for users who have used block explorers of other EVM-compatible chains (e.g. the Etherscan family)

Solution

When "Transaction type" is "Ethereum Transaction":

  • Add a "Sender Account" that shows the address of the account that signed the transaction, as a new field
  • This field should be adjacent to the current "Payer Account" field, as that is the most likely one to be confused with sender account
  • This field should be displayed as:
    • Hedera Account ID (S.R.N format), plus
    • EVM Address Alias (0x... format that isn't "long-zero")

Alternatives

  • Using JSON-RPC to query the same information
  • Using the links from the non-obvious parts of the transactions page
  • While functional, however, both of these approaches are poor UX

Refs

@bguiz bguiz added the enhancement New feature or request label Jun 7, 2023
@bguiz bguiz changed the title feat: Improve understanding of "Payer Account" by adding "Signer Account" field feat: Improve understanding of "Payer Account" by adding "Sender Account" field Jun 7, 2023
@bguiz
Copy link
Author

bguiz commented Jun 10, 2023

This is great, the "from", "to", and "ethereum nonce" fields are much clearer now, thanks!
from-to-and-ethereum-nonce-in-contract-result-section

@bguiz bguiz closed this as completed Jun 10, 2023
@SimiHunjan SimiHunjan added this to the June 2023 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants