00629 Show native EVM address when possible. #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
…n a long-zero form is provided. Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
…beginning. Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Coverage report
Show files with reduced coverage 🔻
Test suite run success327 tests passing in 74 suites. Report generated by 🧪jest coverage report action from 771d8de |
svienot
changed the title
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
|
SonarCloud Quality Gate failed. |
ericleponner
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR refactors the logic of EVMAddress and enhances it such that when the evmAddress argument is a long-zero address, we systematically fetch the corresponding Account information to retrieve its native EVM address in case it holds one.
The compact display now shows 1 byte (instead of 1 digit) before the ellipsis.
Related issue(s):
Related to #629.
It is not confirmed at this point that we want to duplicate the from property found in the Contract Result to show a Sender property in the top section. But in any case we want to make sure the from (and other EVM addresses) show the native EVM address when there is one.
Checklist