Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display topic details using /api/v1/topics/{id} call #1087

Merged
merged 6 commits into from
Jun 5, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Jun 5, 2024

Description:

Leverage the new mirror-node /api/v1/topics/{id} REST API to display topic details.
The 3 properties mandatory in the API result are always displayed: Memo, Valid from and Valid until.
The other (nullable) properties are shown only when their value is non null.

Related issue(s):

Fixes #713

Notes for reviewer:

API available only on previewnet for the time being.

Deployed on staging server.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
…call.

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

github-actions bot commented Jun 5, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 82.86% 39231 / 47345
🔵 Statements 82.86% 39231 / 47345
🔵 Functions 63.06% 888 / 1408
🔵 Branches 84.07% 4103 / 4880
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/pages/TopicDetails.vue 99.17% 88.67% 100% 99.17% 195, 197
src/schemas/HederaSchemas.ts 96.41% 64.28% 87.5% 96.41% 111-125, 314-315, 734, 860-861, 863-864, 880-881, 883-890
src/utils/cache/TopicByIdCache.ts 96.61% 83.33% 100% 96.61% 54-55
Generated in workflow #947

Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (take #2)

@ericleponner ericleponner merged commit 1af68b8 into main Jun 5, 2024
11 of 12 checks passed
@ericleponner ericleponner deleted the 713-add-topic-details-view branch June 5, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search for TopicId returns no result
2 participants