Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add temporary banner related to 60-day transactions history limitation. #1365

Merged
merged 1 commit into from
Sep 18, 2024
Merged

chore: add temporary banner related to 60-day transactions history limitation. #1365

merged 1 commit into from
Sep 18, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Sep 18, 2024

Description:

Banner added to Transactions and AccountDetails view.

Screenshot 2024-09-18 at 18 49 12 Screenshot 2024-09-18 at 18 49 02

@svienot
Add temporary banner for 60-day transactions history issue.
3eb28f6 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
ericleponner
ericleponner approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.59% 23871 / 30763
🔵 Statements 77.59% 23871 / 30763
🔵 Functions 61.26% 952 / 1554
🔵 Branches 84.5% 4618 / 5465
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/pages/AccountDetails.vue 49.33% 84.46% 14.28% 49.33% 1, 27, 29-31, 33-35, 37-38, 41-46, 48-71, 73-78, 80-92, 94-98, 101-106, 109-110, 112-115, 117-118, 120-121, 124-126, 128-130, 132-144, 146, 148-154, 156-160, 162-167, 169, 171-174, 176, 178-180, 182-183, 185-189, 191-192, 194-199, 201-205, 207, 210-216, 218, 220-223, 225, 227-230, 232, 234, 236, 238-240, 242-262, 264-270, 272-274, 276-284, 286-287, 412-418, 422, 424, 467-468, 473-474, 491-493
src/pages/Transactions.vue 100% 100% 50% 100%
Generated in workflow #1290

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarCloud

@svienot svienot merged commit 6fd90ec into main Sep 18, 2024
7 of 8 checks passed
@svienot svienot deleted the 60-day-banner branch September 18, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svienot @ericleponner