Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContractResultsLogsByContractIdCache now returns ContractLog[] #1379

Merged
merged 1 commit into from
Sep 23, 2024
Merged

ContractResultsLogsByContractIdCache now returns ContractLog[] #1379

merged 1 commit into from
Sep 23, 2024

Conversation

ericleponner
Copy link
Collaborator

Description:
Change below update ContractResultsLogsByContractIdCache class: it now returns ContractLog[] in place of ContractResultsLogResponse. No semantic change.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ericleponner
ContractResultsLogsByContractIdCache now returns ContractLog[] in pla…
d28d970 
…ce of ContractResultsLogResponse.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 77.52% 23823 / 30730
🔵 Statements 77.52% 23823 / 30730
🔵 Functions 61.19% 951 / 1554
🔵 Branches 84.51% 4605 / 5449
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/utils/analyzer/ContractResultsLogsAnalyzer.ts 100% 100% 100% 100%
src/utils/cache/ContractResultsLogsByContractIdCache.ts 87.5% 50% 100% 87.5% 41, 46-47
Generated in workflow #1304

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

svienot
svienot approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@ericleponner ericleponner merged commit a4aaaf0 into main Sep 23, 2024
12 checks passed
@ericleponner ericleponner deleted the chore_contract_log branch September 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svienot svienot svienot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericleponner @svienot