New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

00133 going back #247

Merged

svienot merged 40 commits into main from 00133_going_back

Oct 5, 2022

Collaborator

ericleponner commented Oct 5, 2022

Description:

This PR updates table pagination and navigation so that selected page is preserved when user goes back and forth from table to detail page.
This capability is applied to all the tables.

Core changes are located in the TableController generic class.

Related issue(s):

Fixes #133

Notes for reviewer:

This capability can be experimented like this:

Display Transactions tab
Select page Add support for local network #10 in Recent Transactions table
Display Transaction Details for one of the displayed transaction
Click navigator’s Back button
=> Recent Transactions table is displayed
=> Page Add support for local network #10 is selected

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

ericleponner and others added 30 commits

October 3, 2022 17:48


          Added TableControllerV3 and associated classes (to be used later).

0065d35

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Updated EntityBatchLoader.loadNext() to avoid ts lint warning.

cad5ac9

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Fixed TableSubController.headLoad() and lastLoad().

821d6f8

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Fixed AutoRefreshSubController.xxxLoadDidComplete().

19da2a6

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Removed debug trace from TableControllerV3.mountDidChange().

d2b7242

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          TopicDetails.vue is now based on TableControllerV3.

22054b2

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Fixed TableControllerV3.totalRowCount.

35a1ab0

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Fixed PaginationSubController.gotoPage.

75e865a

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Fixed PaginationSubController.gotoPage (take #2).

fd80749

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Added pageParamName and keyParamName to TableControllerV3.

01b00e8

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Added take #1 of TableControllerV3 unit test.

8b0ed05

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Fixed sources watching in TableControllerV3.

7cddcd2

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Added paging test to TableController.spec.ts

fb200ac

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          AccountTableController now based on TableControllerV3.

58aa358

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>


          Fixed PaginationSubController.gotoPage().

dd6e47d

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Added tests to validate TableControllerV3 logic of shadow pages.

c03e549

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Added TableControllerV3.reset() (to be used later).

481d493

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          BlockTableController now based on TableControllerV3.

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>


          ContractTableController now based on TableControllerV3.

b6b299a

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>


          NftHolderTableController now based on TableControllerV3.

f9fc15d

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>


          TokenBalanceTableController now based on TableControllerV3.

9ce2392

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>


          TokenTableController now based on TableControllerV3.

89e66c4

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>


          TransactionTableController now based on TableControllerV3 (however wi…

…th a pending issue concerning transaction type filtering).

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          RewardsTransactionTableController is now based on TransactionControll…

0d9c9fd

…erV3.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Replaced last occurences of PlayPauseButton by PlayPauseButtonV3.

93f8947

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Removed (now obsolete) TableController, PlayPauseButton and RowBuffer…

93e8de0

… classes.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Renamed TableControllerV3 class as TableController.

bde2afd

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Renamed PlayPauseButtonV3 class as PlayPauseButton.

1aaa89b

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Removed debug trace from TableController.routeDidChange().

e4bd403

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Fixed unstable check in Staking.spec.ts.

5145fda

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>

ericleponner added 10 commits

October 3, 2022 17:49


          Adjusted TokenDetails.vue after rebasing.

2e16cae

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Re-worked TableController to enable usage of current route query para…

87b6ab2

…ms by subclasses.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Added comment line in PaginationSubController.unmount() to avoid tsli…

087049d

…nt error.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Moved fetchXXXQueryParam() methods to RouteManager.ts

f4725a5

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          TransactionTableController now adjusts its transaction filter accordi…

f122adf

…ng current route.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Moved PaginationSubController.updateCurrentPage() in TableController.

559dbce

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Fixed TableController.refresh().

fbeda04

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Split TransactionTableController as TransactionTableController and Tr…

58d5325

…ansactionTableControllerXL.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          TableController now enables TransactionTableControllerXL to set up it…

61dc773

…s filter.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>


          Re-enabled e2e test in TransactionNavigation.spec.ts.

5a2b794

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>

ericleponner requested a review from svienot

October 5, 2022 09:36

sonarcloud bot commented Oct 5, 2022

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

No Coverage information
3.7% Duplication

svienot approved these changes

View reviewed changes

svienot merged commit a1611a0 into main

svienot deleted the 00133_going_back branch

October 5, 2022 14:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet