Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

00262 Dashboard tab does not preserve row selection for all tables #270

Merged
merged 16 commits into from
Oct 24, 2022
Merged

00262 Dashboard tab does not preserve row selection for all tables #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8f44f7f
TableController.updateQuery() now preserves existing query params (is…
ericleponner Oct 14, 2022
1f714cc
Added test cases to TableController to guaranty #262 fix.
ericleponner Oct 14, 2022
b9a44ef
Fixed build break in TransactionTableControllerXL.
ericleponner Oct 14, 2022
a42c9bd
Fixed breakage in TableController unit tests.
ericleponner Oct 14, 2022
efa1d74
TransactionTableControllerXL now removes "type" param from route url …
ericleponner Oct 14, 2022
14b2f15
Added extra case to TransactionTableControllerXL unit test.
ericleponner Oct 14, 2022
565dc1b
AutoRefreshSubController now increments autoUpdateCount when in timeo…
ericleponner Oct 19, 2022
dd62769
TableController now delegates some logic to RowBuffer class.
ericleponner Oct 19, 2022
3762cc5
Renamed TransactionTableController.spec.ts as TransactionTableControl…
ericleponner Oct 19, 2022
ba57f7d
Dispatched logic from TableSubController subclasses to TableControlle…
ericleponner Oct 20, 2022
87a8e12
Improved TableController unit by using TestTableController.loadCounter.
ericleponner Oct 21, 2022
727eb84
TransactionTableControllerXL unit test now checks number of REST call…
ericleponner Oct 21, 2022
39adfbf
Added TableController.getAbortedRefreshCounter() and getAbortedMoveTo…
ericleponner Oct 21, 2022
5cc2c04
Added cases to check load aborts in TableController.spec.ts.
ericleponner Oct 21, 2022
956b1d2
TableController.startAutoRefresh() reset current page to 1 before loa…
ericleponner Oct 21, 2022
2d2200d
TableController.startAutoRefresh() reset current page to 1 before loa…
ericleponner Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/components/transaction/TransactionTableControllerXL.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,9 @@ export class TransactionTableControllerXL extends TableController<Transaction, s
pageParamName, keyParamName);
this.accountId = accountId
this.accountIdMandatory = accountIdMandatory
this.watchAndReload([this.transactionType])
this.watchAndReload([this.transactionType, this.accountId])
// this.accountId cannot be treated as this.transactionType :
// when this.accountId changes, we don't want to move to auto-refresh mode.
watch(this.accountId, () => {
if (this.mounted.value) {
this.unmount()
this.mount()
}
})
}

public readonly transactionType: Ref<string> = ref("")
Expand Down Expand Up @@ -121,9 +115,13 @@ export class TransactionTableControllerXL extends TableController<Transaction, s
super.unmount()
}

public makeRouteQuery(): LocationQuery {
protected makeRouteQuery(): LocationQuery {
const result = super.makeRouteQuery()
result[this.typeParamName] = this.transactionType.value.toLowerCase()
if (this.transactionType.value != "") {
result[this.typeParamName] = this.transactionType.value.toLowerCase()
} else {
delete(result[this.typeParamName])
}
return result
}

Expand Down
Loading