00612 Expiration date is confusing until account expiry is turned in #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Coverage report
Show new covered files 🐣
Test suite run success314 tests passing in 71 suites. Report generated by 🧪jest coverage report action from ff67c47 |
|
SonarCloud Quality Gate failed. |
ericleponner
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR add a small InfoTooltip component (explanatory tooltip attached to a circle-info icon) and makes use of it in Account/Contract/Token details pages to clarify the following properties:
Expires atAuto Renew PeriodAuto Renew AccountRelated issue(s):
Fixes #612
Notes for reviewer:
Also deployed on staging server.
Checklist