-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
00627 metadata from runtime bytecode #628
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
…e code and metadata. Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
…PFS hash. Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Coverage report
Show new covered files 🐣
Test suite run success316 tests passing in 72 suites. Report generated by 🧪jest coverage report action from 6c14a4d |
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
…ion vue. Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
SonarCloud Quality Gate failed. |
svienot
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes below enables Contract Details to display metadata encoded in runtime_bytecode:
Those informations are displayed in a new section alongside of
Runtime Bytecode
:When IPFS hash is available,
Contract Details
page also indicates if matching data are available on IPFS (usinghttps://ipfs.io
gateway).Related issue(s):
Fixes #627
Notes for reviewer:
See
0.0.52881
(onpreviewnet
) for a contract with an IPFS hash and matching content available on IPFS.See
0.0.2936092
(onmainnet
) for a contract with a SWARM hash.Checklist