Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

00627 metadata from runtime bytecode #628

Merged
merged 8 commits into from
Jun 7, 2023

Conversation

ericleponner
Copy link
Collaborator

@ericleponner ericleponner commented Jun 6, 2023

Description:

Changes below enables Contract Details to display metadata encoded in runtime_bytecode:

  • solcVersion
  • ipfs hash
  • swarm hash

Those informations are displayed in a new section alongside of Runtime Bytecode:

image

When IPFS hash is available, Contract Details page also indicates if matching data are available on IPFS (using https://ipfs.io gateway).

Related issue(s):

Fixes #627

Notes for reviewer:

See 0.0.52881 (on previewnet) for a contract with an IPFS hash and matching content available on IPFS.
See 0.0.2936092 (on mainnet) for a contract with a SWARM hash.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
…e code and metadata.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
…PFS hash.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@ericleponner ericleponner requested a review from svienot June 6, 2023 13:50
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.63% (+0.14% 🔼)
6021/7561
🟡 Branches
60.75% (+0.15% 🔼)
2459/4048
🟡 Functions
76.11% (+0.25% 🔼)
1163/1528
🟡 Lines
79.68% (+0.13% 🔼)
5696/7149
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / ContractByteCodeSection.vue
100% 91.67% 100% 100%
🟢
... / ByteCodeAnalyzer.ts
94.74% 87.5% 100% 94.29%

Test suite run success

316 tests passing in 72 suites.

Report generated by 🧪jest coverage report action from 6c14a4d

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
…ion vue.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
7.2% 7.2% Duplication

@svienot svienot merged commit fb9eb13 into main Jun 7, 2023
@svienot svienot deleted the 00627_metadata_from_runtime_bytecode branch June 7, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contract Details page should display solcVersion, ipfs/swarm hash info available in runtime_bytecode
2 participants