00602 Transaction wrongly shows a parent transaction property #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
…ilar links. Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Coverage report
Test suite run success317 tests passing in 72 suites. Report generated by 🧪jest coverage report action from 21d2fe5 |
|
SonarCloud Quality Gate failed. |
ericleponner
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Simple change to make sure that a random transaction with nonce=0 is not considered a 'parent' transaction. To be a parent, it also needs to have at least one child (i.e. transaction with same ID and parent_consensus_timestamp property set).
Related issue(s):
Fixes #602
Notes for reviewer:
Without this fix, the following transaction wrongly displays a parent transaction:
https://hashscan.io/mainnet/transaction/1684345315.068887004
Checklist