Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

00626 Clarify nonce and ethereum nonce fields #631

Merged

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Jun 7, 2023

Description:

With these changes:

  • Nonce property in TransactionDetails view is renamed Transaction Nonce
  • Ethereum Nonce property in added to Contract Result section.

Related issue(s):

Fixes #626

Notes for reviewer:

Deployed on staging.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot svienot requested a review from ericleponner June 7, 2023 21:41
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.64% (+0.01% 🔼)
6023/7563
🟡 Branches
60.81% (+0.02% 🔼)
2464/4052
🟡 Functions
76.13% (+0.02% 🔼)
1164/1529
🟡 Lines
79.68% (+0.01% 🔼)
5698/7151

Test suite run success

317 tests passing in 72 suites.

Report generated by 🧪jest coverage report action from 7ad82fb

@sonarcloud
Copy link

sonarcloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
14.3% 14.3% Duplication

@ericleponner ericleponner merged commit ebe7fbb into main Jun 8, 2023
@ericleponner ericleponner deleted the 00626-clarify-transaction-nonce-and-ethereum-nonce branch June 8, 2023 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve understanding of "Nonce" and "Ethereum Nonce" fields
2 participants