Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

00600 Explorer fails to decode call to system contract #643

Merged
merged 6 commits into from
Jun 13, 2023

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below:

  • update Hedera Token Service ABI embedded in Explorer (IHederaTokenService.json)
  • enhanced error processing when decoding input / output / error values from contract call transactions.

When a decoding error is reported by etherjs, Explorer now displays an error message as below:

image

Related issue(s):

Fixes #600

Notes for reviewer:

Uses mainnet transaction 1684236107.179110285 to visualize error message reported when decoding error happens.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@github-actions
Copy link

github-actions bot commented Jun 13, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.97% (+0.66% 🔼)
6087/7612
🟡 Branches
61.55% (+1.03% 🔼)
2518/4091
🟡 Functions
76.38% (+0.18% 🔼)
1174/1537
🟢 Lines
80% (+0.7% 🔼)
5756/7195

Test suite run success

327 tests passing in 74 suites.

Report generated by 🧪jest coverage report action from dad2065

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 13, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
8.2% 8.2% Duplication

@svienot svienot merged commit 0c35c95 into main Jun 13, 2023
@svienot svienot deleted the 00600_decoding_error branch June 13, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explorer fails to decode call to system contract
2 participants