Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

00616 HashScan fails to display token balance when token has very large number of decimals #645

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Jun 15, 2023

Description:

This PR modifies TokenAmount value to deal with cases where token has a decimalCount > 20:

  • display "?" in place of the amount
  • display a (i) icon with explanatory tooltip

Related issue(s):

Fixes #616

Notes for reviewer:

In the token balances:

Screenshot 2023-06-15 at 14 10 54

In the token details:

Screenshot 2023-06-15 at 14 13 38

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.55% (+0.02% 🔼)
6093/7659
🟡 Branches
60.76% (+0.07% 🔼)
2522/4151
🟡 Functions
76.4% (+0.02% 🔼)
1175/1538
🟡 Lines
79.56% (+0.03% 🔼)
5762/7242

Test suite run success

328 tests passing in 74 suites.

Report generated by 🧪jest coverage report action from 36bca6e

@sonarcloud
Copy link

sonarcloud bot commented Jun 15, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ericleponner ericleponner merged commit 3067e04 into main Jun 15, 2023
@ericleponner ericleponner deleted the 00616-token-with-too-many-decimals branch June 15, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HashScan fails to display token balance when token has very large number of decimals
2 participants