Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

00529 rewards subsection #648

Merged
merged 17 commits into from
Jun 22, 2023
Merged

00529 rewards subsection #648

merged 17 commits into from
Jun 22, 2023

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Jun 21, 2023

Description:

This PR brings changes to the Transfers section in Transaction details:

  1. Show the Staking reward transfers in a new subsection.
  2. Display modified amounts in the Hbar transfers by deducing the reward amounts of those, in order to obtain a more intuitive transfer diagram — this allows for instance to distinguish the fee going to 0.0.800
  3. Hide empty sub-sections

Related issue(s):

Fixes #529

Notes for reviewer:

Note this is still a draft while we are collecting internal feedback.

Example of display without the change:
Screenshot 2023-06-21 at 10 52 25

Display with the change:
Screenshot 2023-06-22 at 09 41 53

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@github-actions
Copy link

github-actions bot commented Jun 21, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.61% (+0.11% 🔼)
6142/7715
🟡 Branches
61.12% (+0.41% 🔼)
2587/4233
🟡 Functions
76.42% (+0.06% 🔼)
1180/1544
🟡 Lines
79.61% (+0.1% 🔼)
5807/7294
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / RewardTransferGraph.vue
100% 100% 100% 100%
🟢
... / RewardTransferLayout.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / TransferGraphSection.vue
100%
78.13% (-21.88% 🔻)
100% 100%
🟢
... / HbarTransferLayout.ts
100%
75.76% (-8.11% 🔻)
100% 100%
🟢
... / TokenTransferGraphF.vue
92.31% (-7.69% 🔻)
100%
66.67% (-33.33% 🔻)
91.67% (-8.33% 🔻)

Test suite run success

331 tests passing in 75 suites.

Report generated by 🧪jest coverage report action from e4f2fc3

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

0.0% 0.0% Coverage
0.8% 0.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ericleponner ericleponner merged commit 8b11d3b into main Jun 22, 2023
6 of 7 checks passed
@ericleponner ericleponner deleted the 00529-rewards-subsection branch June 22, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction view does not show accurately where staking rewards are paid
2 participants