Refactoring: removed references to routeManager global variable from RouteManager … #653
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes below are refactoring. No semantic change.
Many methods from
RouteManager
class make reference torouteManager
global variable.They should refer to
this
.Doing this uncovers a latent issue in
RouteManager.selectedNetwork
: this computed value usesthis
to initialize itself which is bad becauseRouteManager
instance is not yet constructed (and thusthis.router
is undefined, and thus it breaks…).