Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: fixed various typing issues reported by typescript 5 #654

Merged
merged 4 commits into from
Jul 4, 2023

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below fix several typing issues reported by typescript 5.
No semantic changes.

…e and errorDecodingFailure are now Ref<unknown>.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
…ialog now have null as default value.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@ericleponner ericleponner requested a review from svienot July 3, 2023 18:21
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
79.72% (+0% 🔼)
6176/7747
🟡 Branches 61.11% 2585/4230
🟡 Functions 76.55% 1188/1552
🟡 Lines
79.7% (+0% 🔼)
5829/7314

Test suite run success

331 tests passing in 75 suites.

Report generated by 🧪jest coverage report action from 9e178b8

@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@svienot svienot merged commit c0dc459 into main Jul 4, 2023
@svienot svienot deleted the refactoring branch July 4, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants