Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

00482 Support for searching via EVM tx hash #675

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below implement search using EVM hash of a transaction.
They also

  • add matching unit and e2e test cases.
  • revisitSearchRequest.ts code using Promise.allSettled() (in place of DeferredPromise).

Related issue(s):

Fixes #482

Notes for reviewer:

Searching for
0x08e62c0531e603fa6d29930195682e937978d542bd404d490546717bb128da4e
now displays:
https://localhost:5173/mainnet/transaction/1674821555.935799283

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 90.79% 29058 / 32005
🔵 Statements 90.79% 29058 / 32005
🔵 Functions 71.72% 728 / 1015
🔵 Branches 84.49% 3373 / 3992
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/utils/SearchRequest.ts 94.73% 84.28% 100% 94.73% 143-146, 173-175, 181-182, 202-203, 285-288, 319-320
Generated in workflow #414

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
5.4% 5.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@svienot svienot merged commit b1d835e into main Aug 1, 2023
5 of 6 checks passed
@svienot svienot deleted the 00482_search_evm_hash branch August 1, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for searching via EVM tx hash
2 participants