Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

00014: Magnifying glass icon should be a button to trigger the search #691

Merged
merged 1 commit into from
Sep 21, 2023
Merged

00014: Magnifying glass icon should be a button to trigger the search #691

merged 1 commit into from
Sep 21, 2023

Conversation

Sheng-Long
Copy link
Contributor

Description:
Changes magnifying glass icon in search bar to an interactable button

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@github-actions
Copy link

github-actions bot commented Sep 12, 2023 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 90.65% 29200 / 32212
🔵 Statements 90.65% 29200 / 32212
🔵 Functions 70.78% 729 / 1030
🔵 Branches 84.5% 3380 / 4000
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/SearchBar.vue 53.52% 66.66% 16.66% 53.52% 28-40, 47, 94-95, 97-110, 113-180, 183
Generated in workflow #461

@Sheng-Long Sheng-Long force-pushed the 00014-magnifying-glass-button branch 3 times, most recently from a40a77b to 1bb8730 Compare September 12, 2023 17:11
@Sheng-Long Sheng-Long force-pushed the 00014-magnifying-glass-button branch 2 times, most recently from b0c6e9b to 303e7b5 Compare September 21, 2023 14:53
@Sheng-Long
feat: magnifying glass on search bar to button
52d4e91 
Signed-off-by: Tim Schmidt <tim@launchbadge.com>
@ericleponner ericleponner changed the title feat: magnifying glass on search to button 00014: Magnifying glass icon should be a button to trigger the search Sep 21, 2023
@ericleponner ericleponner merged commit 64ef46d into main Sep 21, 2023
5 of 6 checks passed
@ericleponner ericleponner deleted the 00014-magnifying-glass-button branch September 21, 2023 14:57
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
5.4% 5.4% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Sheng-Long Sheng-Long mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sheng-Long @ericleponner