Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added new feature to let users decode/encode account.memo #695

Closed
wants to merge 5 commits into from

Conversation

quiet-node
Copy link
Member

@quiet-node quiet-node commented Sep 19, 2023

Description:
This pull request adds a new toggle button that enables users to both encode and decode the account.memo values. The button's visibility is determined by the logic: if account.memo qualifies as a base64 candidate, it will be displayed; otherwise, it remains hidden.

Related issue(s): #694

Fixes #694

UI Demo:

Screen.Recording.2023-09-18.at.7.54.31.PM.mov

** Updated UI **:

Screen.Recording.2023-09-21.at.8.42.11.PM.mov

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the enhancement New feature or request label Sep 19, 2023
@quiet-node quiet-node self-assigned this Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 90.62% 30180 / 33303
🔵 Statements 90.62% 30180 / 33303
🔵 Functions 70.89% 767 / 1082
🔵 Branches 84.19% 3542 / 4207
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/values/BlobValue.vue 86.91% 81.25% 33.33% 86.91% 28, 33, 37-44, 93-96, 127-131, 142-143, 153-154, 167-168
src/pages/AccountDetails.vue 94.38% 82.79% 50% 94.38% 42-46, 104-108, 386-387, 392-393, 400-401, 423-426, 456-457, 470-471, 489-494
Generated in workflow #496

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
…raph/hedera-mirror-node-explorer into 694-Incorrect-memo-display

Signed-off-by: Logan Nguyen <logan.nguyen@swirldslabs.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@svienot
Copy link
Collaborator

svienot commented Nov 28, 2023

As discussed, closing this PR. Issue will be addressed by #775

@svienot svienot closed this Nov 28, 2023
@quiet-node quiet-node deleted the 694-Incorrect-memo-display branch December 4, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect memo display.
2 participants