Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart contract verification phase 1 (still disabled) #698

Merged
merged 18 commits into from
Sep 25, 2023
Merged

Smart contract verification phase 1 (still disabled) #698

merged 18 commits into from
Sep 25, 2023

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Sep 22, 2023 •
edited
Loading

Description:

Integrates the current code for phase 1 of contract verification (i.e. based on hedera-sourcify UI).
The functionality is not available unless following .env variable is set:
VITE_APP_ENABLE_VERIFICATION=true

Related issue(s):

draft implementation for #598

Note

E2E tests currently do not run on GH -- already the case before this PR -- but they all pass locally.
Unit tests related to Staking fail for this PR -- they were passing so far -- but they all pass locally.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

ericleponner and others added 17 commits September 21, 2023 23:17
@ericleponner @svienot
Initialized branch using v6 minus "contract source" section.
3f29885 
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@ericleponner @svienot
Adapted ContractByteCodeSection vue to v6 ContractAnalyzer.
c3b2a05 
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@ericleponner @svienot
ContractByteCodeSection now displays ContractAnalyzer.contractName on…
5df2496 
…ly when contract is verified.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@ericleponner @svienot
Fixed ContractSourceAnalyzer.sourcifyContent.
32afb50 
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@svienot
Point to sourcify test instance on https://verify.simonvienot.fr
a331312 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@ericleponner @svienot
Updated package-lock.json after rebasing.
60cb979 
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@ericleponner @svienot
Added import clause to ContractAnalyzer.spec.ts (lost during rebasing).
06ce293 
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@ericleponner @svienot
Added --threads false option to avoid vitest crash.
c49168c 
Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@ericleponner @svienot
networks-config.json now points to https://sourcify-integration.heder…
8870699 
…a-devops.com.

Signed-off-by: Eric Le Ponner <eric.leponner@icloud.com>
@svienot
Revert "networks-config.json now points to https://sourcify-integrati…
fa0595c 
…on.hedera-devops.com."

This reverts commit 8870699.
@svienot
Some renaming in ContractByteCodeSection view
77ba224 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Do not display IPFS or Swarm Hash properties when their value is not …
bb27bce 
…present

Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Update unit tests for IPFS & Swarm Hash properties.
a03f061 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Re-order ContractByteCodeSection properties
f9ad3db 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Fix unit test.
d006dd8 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Contract verification is enabled by environment variable
7d167d8 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Add unit test for verification links and properties.
070af53 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot svienot linked an issue Sep 22, 2023 that may be closed by this pull request
Smart contract verification UI/UX implemented with the native Sourcify experience #598
Closed
@svienot svienot removed a link to an issue Sep 22, 2023
Smart contract verification UI/UX implemented with the native Sourcify experience #598
Closed
@svienot
Get rid of (now unused) getEnv.ts
1b8f152 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 16 Code Smells

0.0% 0.0% Coverage
4.9% 4.9% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ericleponner ericleponner merged commit f545a3b into main Sep 25, 2023
4 of 8 checks passed
@ericleponner ericleponner deleted the 00598_contract_verif branch September 25, 2023 07:23
@svienot svienot mentioned this pull request Sep 25, 2023
Closed
@svienot svienot linked an issue Oct 23, 2023 that may be closed by this pull request
Smart contract verification UI/UX implemented with the native Sourcify experience #598
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Smart contract verification UI/UX implemented with the native Sourcify experience
2 participants
@svienot @ericleponner