fix: allow Helm templating for proxyPass value #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #725 Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
leninmehedy
force-pushed
the
725-allow-helm-templating-for-proxypass-value
branch
from
fbe5ee9
to
009e94a
Compare
Coverage Report
File CoverageNo changed files found. |
leninmehedy
changed the title
leninmehedy
changed the title
This was referenced Oct 16, 2023
Signed-off-by: Lenin Mehedy <lenin.mehedy@swirldslabs.com>
|
Kudos, SonarCloud Quality Gate passed!
|
steven-sheehy
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR allows helm templating for
proxyPassvalue so that end-user is able to deploy their chart with any custom release name without hardcoding theproxyPassvalue in their values.yaml fileRelated issue(s):
Fixes #725
Notes for reviewer:
I have tested it in FST chart and a relevant fix is here: hashgraph/full-stack-testing#413
Checklist