Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add beta mention to contract verification #733

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Add beta mention to contract verification #733

merged 2 commits into from
Oct 18, 2023

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Oct 18, 2023

Description:

Screenshot 2023-10-16 at 23 21 33 Screenshot 2023-10-16 at 23 21 01

@svienot
Add beta mention.
1f0f949 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot
Adjust unit test to beta mention.
f5ade66 
Signed-off-by: Simon Viénot <simon.vienot@icloud.com>
@svienot svienot requested a review from 0xivanov October 18, 2023 11:55
@github-actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 88.82% 31434 / 35389
🔵 Statements 88.82% 31434 / 35389
🔵 Functions 68.6% 782 / 1140
🔵 Branches 83.98% 3591 / 4276
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/contract/ContractByteCodeSection.vue 99.39% 76.47% 100% 99.39% 125
Generated in workflow #534

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell C 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@svienot svienot requested review from ericleponner and removed request for 0xivanov October 18, 2023 16:33
@ericleponner ericleponner merged commit 105a323 into main Oct 18, 2023
7 of 8 checks passed
@ericleponner ericleponner deleted the prepare-verif-beta branch October 18, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svienot @ericleponner